[Bug 194523] New: x11/nvidia-driver: nvidia_sysctl.c:38:5: error: static_assert failed "compile-time assertion failed" SYSCTL_ADD_STRING(&sysctl_ctx,

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194523

            Bug ID: 194523
           Summary: x11/nvidia-driver: nvidia_sysctl.c:38:5: error:
                    static_assert failed "compile-time assertion failed"
                      SYSCTL_ADD_STRING(&sysctl_ctx,
           Product: Ports Tree
           Version: Latest
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: danfe at FreeBSD.org
          Reporter: jbeich at vfemail.net
                CC: hselasky at FreeBSD.org
          Assignee: danfe at FreeBSD.org
             Flags: maintainer-feedback?(danfe at FreeBSD.org)

Created attachment 148557
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=148557&action=edit
fix

Looks to be a fallout from base r273377. Dynamic sysctl macros (or any
non-custom) already add correct CTLTYPE_*. The newly added CTASSERT chokes on
overspecifying e.g.,

  --- nvidia_sysctl.o ---
  nvidia_sysctl.c:38:5: error: static_assert failed "compile-time assertion
failed"
      SYSCTL_ADD_STRING(&sysctl_ctx,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  @/sys/sysctl.h:303:2: note: expanded from macro 'SYSCTL_ADD_STRING'
          CTASSERT(((access) & CTLTYPE) == 0);                            \
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  @/sys/systm.h:102:21: note: expanded from macro 'CTASSERT'
  #define CTASSERT(x)     _Static_assert(x, "compile-time assertion failed")
                          ^              ~
  nvidia_sysctl.c:259:5: error: static_assert failed "compile-time assertion
failed"
      SYSCTL_ADD_UINT(&sc->sysctl_ctx,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  @/sys/sysctl.h:338:2: note: expanded from macro 'SYSCTL_ADD_UINT'
          CTASSERT(((access) & CTLTYPE) == 0);                            \
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  @/sys/systm.h:102:21: note: expanded from macro 'CTASSERT'
  #define CTASSERT(x)     _Static_assert(x, "compile-time assertion failed")
                          ^              ~
  2 errors generated.
  *** [nvidia_sysctl.o] Error code 1

Tested only on nvidia-driver-343.22. The patch also contains OSVERSION check
for imminent MFC to /stable/10.

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Auto-assigned to maintainer danfe at FreeBSD.org

-- 
You are receiving this mail because:
You are the assignee for the bug.