ports/189881: [patch] net/freeradius3 fix segfault, sort pkg-plist again with changed makeplist
Olli Hauer
ohauer at FreeBSD.org
Sat May 17 11:00:04 UTC 2014
>Number: 189881
>Category: ports
>Synopsis: [patch] net/freeradius3 fix segfault, sort pkg-plist again with changed makeplist
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat May 17 11:00:03 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Olli Hauer
>Release:
>Organization:
>Environment:
>Description:
FreeRADIUS 3.0.3 segfaults during start
Patch obtained from
https://github.com/FreeRADIUS/freeradius-server/issues/634
Since the output from `make makeplist' has changed between stagify
the port and today reorder pkg-plist again.
>How-To-Repeat:
$ gdb radiusd
> run -X
...
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 801a041c0 (LWP 100840/initial thread)]
0x0000000800dee052 in _talloc_free () from /usr/local/lib/libtalloc.so.2
(gdb) bt
#0 0x0000000800dee052 in _talloc_free () from /usr/local/lib/libtalloc.so.2
#1 0x000000080069d859 in cf_item_parse () from /usr/local/lib/freeradius-3.0.3/libfreeradius-server.so
#2 0x000000080069e053 in cf_section_parse () from /usr/local/lib/freeradius-3.0.3/libfreeradius-server.so
#3 0x000000000041993a in main_config_init ()
#4 0x0000000000420dc7 in main ()
(gdb)
>Fix:
--- freeradius3.diff begins here ---
Index: freeradius3/Makefile
===================================================================
--- freeradius3/Makefile (revision 354307)
+++ freeradius3/Makefile (working copy)
@@ -3,6 +3,7 @@
PORTNAME= freeradius
DISTVERSION= 3.0.3
+PORTREVISION= 1
CATEGORIES= net
MASTER_SITES= ftp://ftp.freeradius.org/pub/freeradius/%SUBDIR%/ \
ftp://ftp.ntua.gr/pub/net/radius/freeradius/%SUBDIR%/ \
Index: freeradius3/files/patch-src__main__mainconfig.c
===================================================================
--- freeradius3/files/patch-src__main__mainconfig.c (revision 0)
+++ freeradius3/files/patch-src__main__mainconfig.c (working copy)
@@ -0,0 +1,14 @@
+Fix FreeRADIUS 3.0.3 crash
+https://github.com/FreeRADIUS/freeradius-server/issues/634
+==================================================================
+--- ./src/main/mainconfig.c.orig 2014-05-17 11:19:37.000000000 +0200
++++ ./src/main/mainconfig.c 2014-05-17 11:20:09.000000000 +0200
+@@ -83,7 +83,7 @@
+ */
+ static char const *localstatedir = NULL;
+ static char const *prefix = NULL;
+-static char my_name;
++static char const *my_name = NULL;
+ static char const *sbindir = NULL;
+ static char const *run_dir = NULL;
+ static char *syslog_facility = NULL;
Property changes on: freeradius3/files/patch-src__main__mainconfig.c
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: freeradius3/pkg-plist
===================================================================
--- freeradius3/pkg-plist (revision 354307)
+++ freeradius3/pkg-plist (working copy)
@@ -832,66 +832,66 @@
%%DATADIR%%/dictionary.zeus
%%DATADIR%%/dictionary.zte
%%DATADIR%%/dictionary.zyxel
- at unexec rmdir "/var/run/radiusd" >/dev/null 2>&1 || :
- at unexec rmdir "/var/log/radacct" >/dev/null 2>&1 || :
- at dirrm %%DATADIR%%
- at dirrm %%EXAMPLESDIR%%/raddb/sites-enabled
- at dirrm %%EXAMPLESDIR%%/raddb/sites-available
- at dirrm %%EXAMPLESDIR%%/raddb/policy.d
- at dirrm %%EXAMPLESDIR%%/raddb/mods-enabled
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/unbound
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/sqlite
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/postgresql/extras
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/postgresql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/oracle
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/ndb
+ at dirrm include/freeradius
+ at dirrm %%LIBDIR%%
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/concepts
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/configuration
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/deployment
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/developer
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/modules
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/rfc
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/schemas/ldap
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/schemas
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/vendor
+%%PORTDOCS%%@dirrm %%DOCSDIR%%
+ at dirrm %%EXAMPLESDIR%%/raddb/certs
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-available
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/attr_filter
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/files
+%%RLMPERL%%@dirrm %%EXAMPLESDIR%%/raddb/mods-config/perl
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/preprocess
+%%RLMPYTHON%%@dirrm %%EXAMPLESDIR%%/raddb/mods-config/python
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/mysql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/postgresql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/sqlite
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/mysql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/postgresql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/sqlite
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/mysql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/oracle
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/postgresql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/sqlite
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/mysql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/oracle
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/sqlite
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mssql
@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mysql/extras/wimax
@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mysql/extras
@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mysql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/mssql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/ndb
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/oracle
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/postgresql/extras
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/postgresql
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main/sqlite
@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/main
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/sqlite
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/postgresql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/oracle
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool/mysql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/sqlite
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/oracle
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp/mysql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool-dhcp
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/ippool
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/sqlite
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/postgresql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui/mysql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/cui
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/sqlite
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/postgresql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter/mysql
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql/counter
@dirrm %%EXAMPLESDIR%%/raddb/mods-config/sql
-%%RLMPYTHON%%@dirrm %%EXAMPLESDIR%%/raddb/mods-config/python
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/preprocess
-%%RLMPERL%%@dirrm %%EXAMPLESDIR%%/raddb/mods-config/perl
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/files
- at dirrm %%EXAMPLESDIR%%/raddb/mods-config/attr_filter
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-config/unbound
@dirrm %%EXAMPLESDIR%%/raddb/mods-config
- at dirrm %%EXAMPLESDIR%%/raddb/mods-available
- at dirrm %%EXAMPLESDIR%%/raddb/certs
+ at dirrm %%EXAMPLESDIR%%/raddb/mods-enabled
+ at dirrm %%EXAMPLESDIR%%/raddb/policy.d
+ at dirrm %%EXAMPLESDIR%%/raddb/sites-available
+ at dirrm %%EXAMPLESDIR%%/raddb/sites-enabled
@dirrm %%EXAMPLESDIR%%/raddb
@dirrm %%EXAMPLESDIR%%
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/vendor
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/schemas/ldap
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/schemas
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/rfc
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/modules
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/developer
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/deployment
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/configuration
-%%PORTDOCS%%@dirrm %%DOCSDIR%%/concepts
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
- at dirrm %%LIBDIR%%
- at dirrm include/freeradius
+ at dirrm %%DATADIR%%
@exec if ! [ -d %D/etc/raddb -o -L %D/etc/raddb ]; then cp -RP %D/%%EXAMPLESDIR%%/raddb %D/etc/raddb; echo '===> Bootstrapping default certificates, please wait...'; %D/etc/raddb/certs/bootstrap >/dev/null 2>&1; fi
@exec chmod -R g-w,o-rwx %D/etc/raddb
@exec if [ ! -d /var/log/radacct ]; then mkdir -p /var/log/radacct; chmod -R go= /var/log/radacct; fi
@exec for i in /var/log/radius.log /var/log/radutmp /var/log/radwtmp; do if [ ! -f ${i} ]; then touch ${i}; chmod go= ${i}; fi; done
@exec mkdir -p /var/run/radiusd
+ at unexec rmdir "/var/log/radacct" >/dev/null 2>&1 || :
+ at unexec rmdir "/var/run/radiusd" >/dev/null 2>&1 || :
--- freeradius3.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list