ports/189381: astro/cfitsio : needs its own zlib

[Christoph Moench-Tegeder]

>Number:         189381
>Category:       ports
>Synopsis:       astro/cfitsio : needs its own zlib
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 05 19:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Christoph Moench-Tegeder
>Release:        FreeBSD 10.0-RELEASE-p2 amd64
>Organization:
>Environment:
System: FreeBSD elch.exwg.net 10.0-RELEASE-p2 FreeBSD 10.0-RELEASE-p2 #4 r265158: Wed Apr 30 22:41:03 CEST 2014 cmt at elch.exwg.net:/usr/obj/usr/src/sys/ELCH amd64


	cfitsio-3.360                  astro/cfitsio
	ufraw-0.19.2_4                 graphics/ufraw

>Description:
	When building ufraw (and others) with cfitsio support (optional
	via OPTIONS) againts cfitsio-3.360, linking fails with

: c++  -O2 -pipe -march=core2 -fno-strict-aliasing   -L/usr/local/lib -pthread -lz -o nikon-curve  nikon_curve-nikon_curve.o -L/usr/local/lib -lexiv2   -lgthread-2.0 -pthread -L/usr/local/lib -lglib-2.0 -lintl   -L/usr/local/lib -llcms   -L/usr/local/lib/ -llensfun -L/usr/local/lib -lglib-2.0 -lintl   -L/usr/local/lib -ltiff   -L/usr/local/lib -lpng15   -L/usr/local/lib -lcfitsio    -ljasper -ljpeg -lbz2 -lz -lm  -lintl 
(omitted)
: /usr/local/lib/libcfitsio.so: undefined reference to `compress2file_from_mem'
: /usr/local/lib/libcfitsio.so: undefined reference to `compress2mem_from_mem'
: /usr/local/lib/libcfitsio.so: undefined reference to `uncompress2file'
: /usr/local/lib/libcfitsio.so: undefined reference to `uncompress2mem_from_mem'
: /usr/local/lib/libcfitsio.so: undefined reference to `uncompress2mem'
: /usr/local/lib/libcfitsio.so: undefined reference to `zuncompress2mem'
: c++: error: linker command failed with exit code 1 (use -v to see invocation)

I've seen a very similar error with graphics/gdal (when cfitsio-enabled), but
failed to safe the error message befor fixing citsio).

These functions are defined in cfitsio's private copy of zlib, but not in
our (at least 10.0-RELEASE) zlib (see cfitsio/zlib/zuncompress.c - the
system zlib does not have zuncompress.c and does not know about
uncompress2mem() and the like).
cfitsio's private zlib is disabled by editing cfitsio/Makefile.in
in post-patch. 

>How-To-Repeat:
	
>Fix:

Do not lobotimize cfitsio (and bump PORTREVISION, to get a rebuild):
Patch for astro/cfitsio:

Index: Makefile
===================================================================
--- Makefile	(revision 353037)
+++ Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	cfitsio
 PORTVERSION=	3.360
+PORTREVISION=	1
 CATEGORIES=	astro
 MASTER_SITES=	http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/ \
 		http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/oldvers/ \
@@ -36,9 +37,6 @@
 SHLIB_MAJOR_VER=2
 SHLIB_MINOR_VER=${PORTVERSION:S/0$//}
 
-post-patch:
-	@${REINPLACE_CMD} -e 's|$${ZLIB_SOURCES[:=a-z\.]*}||' ${WRKSRC}/Makefile.in
-
 do-install:
 	cd ${WRKSRC}/ && ${INSTALL_DATA} drvrsmem.h fitsio.h fitsio2.h longnam.h ${STAGEDIR}${PREFIX}/include/
 	cd ${WRKSRC}/ && ${INSTALL_LIB} libcfitsio.a libcfitsio.so.${SHLIB_MAJOR_VER}.${SHLIB_MINOR_VER} ${STAGEDIR}${PREFIX}/lib/



Regards,
Christoph
>Release-Note:
>Audit-Trail:
>Unformatted: