ports/187730: lang/gcl compilation fails ()

[Mamoru Iwaki]

>Number:         187730
>Category:       ports
>Synopsis:       lang/gcl compilation fails ()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 19 09:50:01 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Mamoru Iwaki
>Release:        FreeBSD  10.0-STABLE FreeBSD 10.0-STABLE #0 r263331
>Organization:
>Environment:
FreeBSD  10.0-STABLE FreeBSD 10.0-STABLE #0 r263331: Wed Mar 19 14:26:49 JST 2014     root@:/mnt2/usr/obj/nanobsd.full/mnt2/usr/src/sys/MYGEN  amd64
>Description:
Re: # $FreeBSD: head/lang/gcl/Makefile 347809 2014-03-10 20:55:20Z gerald $

Compilation of lang/gcl has failed these days.  

As the following message said, 'CPPFunction' at gcl_readline.d:472:39 is not declared. And the lhs value of the above line is not used anywhere.  It looks very strange.  I simply guess this line should be removed.  


root@:/usr/ports/lang/gcl # make
===>  License GPLv2 LGPL21 accepted by the user
===>  Found saved configuration for gcl-2.6.10_1
===>   gcl-2.6.10_1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by gcl-2.6.10_1 for building
===>  Extracting for gcl-2.6.10_1
=> SHA256 Checksum OK for gcl-2.6.10.tar.gz.
===>  Patching for gcl-2.6.10_1
===>  Applying FreeBSD patches for gcl-2.6.10_1

(snip-snip-snip)

./bin/dpp gcl_readline
dpp: gcl_readline.d -> gcl_readline.c
gcc47 -c -O2 -pipe -I/usr/local/include -Wl,-rpath=/usr/local/lib/gcc47 -fno-strict-aliasing -fomit-frame-pointer -fsigned-char -DVOL=volatile -I/mnt2/usr/ports/lang/gcl/work/gcl/o -Wall -UDBEGIN -DDBEGIN=0 -I../h -I../gcl-tk gcl_readline.c
gcl_readline.d: In function 'gcl_init_readline_function':
gcl_readline.d:472:39: error: 'CPPFunction' undeclared (first use in this function)
gcl_readline.d:472:39: note: each undeclared identifier is reported only once for each function it appears in
gcl_readline.d:472:52: error: expected expression before ')' token
gcl_readline.d: At top level:
gcl_readline.d:224:15: warning: 'rl_completion' defined but not used [-Wunused-function]
gmake[3]: *** [gcl_readline.o] Error 1
gmake[3]: Leaving directory `/mnt2/usr/ports/lang/gcl/work/gcl/o'
gmake[2]: *** [unixport/saved_pre_gcl] Error 2
gmake[2]: Leaving directory `/mnt2/usr/ports/lang/gcl/work/gcl'
*** Error code 1

Stop.
make[1]: stopped in /mnt2/usr/ports/lang/gcl
*** Error code 1

Stop.
make: stopped in /mnt2/usr/ports/lang/gcl
root@:/usr/ports/lang/gcl #



NOTE: /usr/ports is a symlink to /mnt2/usr/ports in my environmnet.

>How-To-Repeat:
Simply try compiling it

cd /usr/ports/lang/gcl
make
(No option is changed)

>Fix:
I made this patch to remove useless lines, based on the above guess.  It looks working for me for now.

% cat patch-o_gcl_readline.d
--- o/gcl_readline.d.orig	2013-11-11 23:55:48.000000000 +0900
+++ o/gcl_readline.d	2014-03-19 17:58:06.000000000 +0900
@@ -468,9 +468,11 @@
   static int n;
   char *pn="GCL",*cp=getenv("TERM");
   rl_readline_name=pn;
+/*
 #ifdef RL_COMPLETION
   rl_attempted_completion_function = (CPPFunction *)rl_completion;
 #endif		
+*/
   if (isatty(0) && (!cp || strcmp(cp,"dumb")))
     readline_on=1;
   if (!n) {


Patch attached with submission follows:

--- o/gcl_readline.d.orig	2013-11-11 23:55:48.000000000 +0900
+++ o/gcl_readline.d	2014-03-19 17:58:06.000000000 +0900
@@ -468,9 +468,11 @@
   static int n;
   char *pn="GCL",*cp=getenv("TERM");
   rl_readline_name=pn;
+/*
 #ifdef RL_COMPLETION
   rl_attempted_completion_function = (CPPFunction *)rl_completion;
 #endif		
+*/
   if (isatty(0) && (!cp || strcmp(cp,"dumb")))
     readline_on=1;
   if (!n) {


>Release-Note:
>Audit-Trail:
>Unformatted: