ports/186219: net-mgmt/libsmi - Clang / GCC issue

[Marcin Cieslak]

The following reply was made to PR ports/186219; it has been noted by GNATS.

From: Marcin Cieslak <saper at saper.info>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: ports/186219: net-mgmt/libsmi - Clang / GCC issue
Date: Wed, 29 Jan 2014 16:21:00 +0000

 On Wed, 29 Jan 2014, Edwin Groothuis wrote:
 
 > Maintainer of net-mgmt/libsmi,
 > 
 > Please note that PR ports/186219 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 
 Thanks, there is a fix in the SVN already,
 
 ===> Generating patch
 ===> Viewing diff with more
 diff -ruN --exclude=CVS /usr/ports/net-mgmt/libsmi.orig/Makefile /usr/ports/net-mgmt/libsmi/Makefile
 --- /usr/ports/net-mgmt/libsmi.orig/Makefile	2014-01-29 17:15:07.000000000 +0100
 +++ /usr/ports/net-mgmt/libsmi/Makefile	2014-01-29 17:19:09.000000000 +0100
 @@ -3,6 +3,7 @@
  
  PORTNAME=	libsmi
  PORTVERSION=	0.4.8
 +PORTREVISION=	1
  CATEGORIES=	net-mgmt
  MASTER_SITES=	ftp://ftp.ibr.cs.tu-bs.de/pub/local/libsmi/ \
  		LOCAL/bms
 diff -ruN --exclude=CVS /usr/ports/net-mgmt/libsmi.orig/files/patch-cppcompat /usr/ports/net-mgmt/libsmi/files/patch-cppcompat
 --- /usr/ports/net-mgmt/libsmi.orig/files/patch-cppcompat	1970-01-01 01:00:00.000000000 +0100
 +++ /usr/ports/net-mgmt/libsmi/files/patch-cppcompat	2014-01-29 17:15:07.000000000 +0100
 @@ -0,0 +1,32 @@
 +--- lib/smi.h.in.orig	2008-04-18 14:56:31.000000000 +0200
 ++++ lib/smi.h.in	2014-01-29 17:11:40.000000000 +0100
 +@@ -312,9 +312,10 @@
 + 
 + /* SmiElement -- an item in a list (row index column, notification object)   */
 + typedef struct SmiElement {
 +-#ifndef __GNUC__
 +-    char dummy;		/* many compilers are unhappy with empty structures. */
 +-#endif
 ++    char dummy;		/* C99 does not allow empty structs; some compilers
 ++			   accept them (gcc) but there are size differences
 ++			   between C and C++. So for portability reasons,
 ++			   we have this unused struct member. */
 +     /* no visible attributes */
 + } SmiElement;
 + 
 +--- lib/smi.h.orig	2008-04-18 14:58:06.000000000 +0200
 ++++ lib/smi.h	2014-01-29 17:11:59.000000000 +0100
 +@@ -312,9 +312,10 @@
 + 
 + /* SmiElement -- an item in a list (row index column, notification object)   */
 + typedef struct SmiElement {
 +-#ifndef __GNUC__
 +-    char dummy;		/* many compilers are unhappy with empty structures. */
 +-#endif
 ++    char dummy;		/* C99 does not allow empty structs; some compilers
 ++			   accept them (gcc) but there are size differences
 ++			   between C and C++. So for portability reasons,
 ++			   we have this unused struct member. */
 +     /* no visible attributes */
 + } SmiElement;
 + 
 ===> Done