ports/186027: [PATCH] race in ports/audio/liba52 install target

[Chad J. Milios]

>Number:         186027
>Category:       ports
>Synopsis:       [PATCH] race in ports/audio/liba52 install target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 23 00:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Chad J. Milios
>Release:        9.2-RELEASE-p3
>Organization:
Crop Circle Systems, Inc.
>Environment:
FreeBSD kakashi.ccsys.com 9.2-RELEASE-p3 FreeBSD 9.2-RELEASE-p3 #0 r259093: Thu Dec 12 23:34:17 UTC 2013     root at shikamaru.ccsys.com:/usr/obj/usr/src/sys/NUOS  amd64
>Description:
50% of the time the install target errors out with this:

/bin/mkdir -p /usr/ports/audio/liba52/work/stage/usr/local/share/doc/liba52
install  -o root -g wheel -m 444 /usr/ports/audio/liba52/work/a52dec-0.7.4/doc/liba52.txt /usr/ports/audio/liba52/work/stage/usr/local/share/doc/liba52
install  -o root -g wheel -m 444 /usr/ports/audio/liba52/work/a52dec-0.7.4/liba52/a52_internal.h /usr/ports/audio/liba52/work/stage/usr/local/include/a52dec
/usr/bin/strip /usr/ports/audio/liba52/work/stage/usr/local/lib/liba52.so.0
/usr/bin/strip: '/usr/ports/audio/liba52/work/stage/usr/local/lib/liba52.so.0': No such file
*** [post-install] Error code 1

Stop in /usr/ports/audio/liba52.
*** [stage] Error code 1

Stop in /usr/ports/audio/liba52.

>How-To-Repeat:
cd /usr/ports/audio/liba52 && make install
>Fix:
apply the attached patch adding a pre-install target of:

pre-install:
	${FIND} ${WRKSRC} -name Makefile | ${XARGS} ${TOUCH}


Patch attached with submission follows:

--- /usr/ports/audio/liba52/Makefile.orig	2014-01-23 00:24:45.415744001 +0000
+++ /usr/ports/audio/liba52/Makefile	2014-01-23 00:23:28.546933261 +0000
@@ -46,6 +46,9 @@
 	@${REINPLACE_CMD} -E -e 's|(fftc4.h)|djbfft/\1|' ${WRKSRC}/liba52/imdct.c
 .endif
 
+pre-install:
+	${FIND} ${WRKSRC} -name Makefile | ${XARGS} ${TOUCH}
+
 post-install:
 	${MKDIR} ${STAGEDIR}${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/doc/liba52.txt ${STAGEDIR}${DOCSDIR}


>Release-Note:
>Audit-Trail:
>Unformatted: