ports/185881: [patch] dns/ddclient does not start after update to 3.8.2

[Matthew Luckie]

>Number:         185881
>Category:       ports
>Synopsis:       [patch] dns/ddclient does not start after update to 3.8.2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 19 16:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Matthew Luckie
>Release:        FreeBSD 9.2-RELEASE-p3 i386
>Organization:
>Environment:
System: FreeBSD spandex.luckie.org.nz 9.2-RELEASE-p3 FreeBSD 9.2-RELEASE-p3 #0: Tue Jan 14 22:06:10 PST 2014 root@:/usr/src/sys/i386/compile/spandex i386


	
>Description:
with the recent update to net/ddclient, the script looks for its configuration
file at /usr/local/etc/ddclient/ddclient.conf, but the port is directing the
user to /usr/local/etc/ddclient.conf

Starting ddclient.
WARNING:  file /usr/local/etc/ddclient/ddclient.conf: Cannot open file '/usr/local/etc/ddclient/ddclient.conf'. (No such file or directory)
stat() on closed filehandle FD at /usr/local/sbin/ddclient line 1003.
Use of uninitialized value $mode in bitwise and (&) at /usr/local/sbin/ddclient line 1004.
readline() on closed filehandle FD at /usr/local/sbin/ddclient line 1016.
WARNING:  file /usr/local/etc/ddclient/ddclient.conf: Cannot open file '/usr/local/etc/ddclient/ddclient.conf'. (No such file or directory)
stat() on closed filehandle FD at /usr/local/sbin/ddclient line 1003.
Use of uninitialized value $mode in bitwise and (&) at /usr/local/sbin/ddclient line 1004.
readline() on closed filehandle FD at /usr/local/sbin/ddclient line 1016.
/usr/local/etc/rc.d/ddclient: WARNING: failed to start ddclient

>How-To-Repeat:
Update from 3.8.1_1 to 3.8.2 and restart ddclient

>Fix:

the attached patch updates the port to what ddclient expects.  an entry
in ports/UPDATING probably would be a good idea.  alternatively, the
script could be changed to look in the old configuration file location.

the patch also offers to take maintainer.

--- patch-ddclient begins here ---
diff -uNr ddclient.orig/Makefile ddclient/Makefile
--- ddclient.orig/Makefile	2014-01-18 18:04:22.000000000 -0800
+++ ddclient/Makefile	2014-01-19 07:55:54.000000000 -0800
@@ -6,7 +6,7 @@
 CATEGORIES=	dns
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION}
 
-MAINTAINER=	ports at FreeBSD.org
+MAINTAINER=	mjl at luckie.org.nz
 COMMENT=	Update dynamic DNS entries
 
 LICENSE=	GPLv2
@@ -30,7 +30,8 @@
 PORTDOCS=	COPYRIGHT Changelog README.cisco README.ssl README.md \
 		sample-etc_cron.d_ddclient sample-etc_dhclient-exit-hooks \
 		sample-etc_dhcpc_dhcpcd-eth0.exe sample-etc_ppp_ip-up.local
-PLIST_FILES=	etc/ddclient.conf.sample etc/periodic/daily/ddclient_force \
+PLIST_FILES=	etc/ddclient/ddclient.conf.sample \
+		etc/periodic/daily/ddclient_force \
 		sbin/ddclient
 PLIST_DIRSTRY=	etc/periodic/daily etc/periodic
 
@@ -43,8 +44,9 @@
 		 s|%%LOCALBASE%%|${LOCALBASE}|' ${WRKSRC}/ddclient
 
 do-install:
+	@${MKDIR} ${STAGEDIR}${PREFIX}/etc/ddclient
 	(cd ${WRKSRC} && ${INSTALL_DATA} sample-etc_ddclient.conf \
-		${STAGEDIR}${PREFIX}/etc/ddclient.conf.sample)
+		${STAGEDIR}${PREFIX}/etc/ddclient/ddclient.conf.sample)
 	(cd ${WRKSRC} && ${INSTALL_SCRIPT} ddclient \
 		${STAGEDIR}${PREFIX}/sbin)
 	@${MKDIR} ${STAGEDIR}${PREFIX}/etc/periodic/daily
diff -uNr ddclient.orig/files/ddclient.in ddclient/files/ddclient.in
--- ddclient.orig/files/ddclient.in	2012-07-14 06:54:48.000000000 -0700
+++ ddclient/files/ddclient.in	2014-01-19 07:42:56.000000000 -0800
@@ -20,7 +20,7 @@
 rcvar=ddclient_enable
 
 command="%%PREFIX%%/sbin/${name}"
-required_files="%%PREFIX%%/etc/${name}.conf"
+required_files="%%PREFIX%%/etc/ddclient/${name}.conf"
 
 load_rc_config ${name}
 
diff -uNr ddclient.orig/files/pkg-message.in ddclient/files/pkg-message.in
--- ddclient.orig/files/pkg-message.in	2012-07-14 06:54:48.000000000 -0700
+++ ddclient/files/pkg-message.in	2014-01-19 07:53:30.000000000 -0800
@@ -1,9 +1,9 @@
 ***********************************************************
 
 Copy
-	%%PREFIX%%/etc/ddclient.conf.sample
+	%%PREFIX%%/etc/ddclient/ddclient.conf.sample
 to
-	%%PREFIX%%/etc/ddclient.conf
+	%%PREFIX%%/etc/ddclient/ddclient.conf
 
 and edit it to fit your needs.
 
--- patch-ddclient ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: