ports/185647: [PATCH] graphics/darktable: update to 1.4

[Jean-Sébastien Pédron]

>Number:         185647
>Category:       ports
>Synopsis:       [PATCH] graphics/darktable: update to 1.4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 10 21:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jean-Sébastien Pédron
>Release:        11.0-CURRENT
>Organization:
The FreeBSD Project
>Environment:
FreeBSD magellan.dumbbell.fr 11.0-CURRENT FreeBSD 11.0-CURRENT #0 47c5296(master): Sat Jan  4 15:00:43 CET 2014     root at magellan.dumbbell.fr:/usr/obj/home/dumbbell/Projects/freebsd/src/GIT/sys/GENERIC  amd64
>Description:
The following patch stages and updates graphics/darktable to 1.4:
http://people.freebsd.org/~dumbbell/darktable/ports-graphics-darktable-140.2.patch

The following changes were made to options:
  - Remove KWALLET option (unused)
  - Rename FACEBOOK option to FB_PICASA, because both export features depend on json-glib.
  - Add COLORD option (color management)
  - Add GRAPHMAGICK option (support GraphicsMagick's image formats)
  - Add LUA option (embed Lua to add scripting)
  - Add SQUISH option (use libsquish to compress thumbnails)
  - Add WEBP option (support WebP image format)

The patch enables more options by default, because I think it's more sensible for a photographer using binary packages:
  - COLORD
  - FB_PICASA
  - FLICKR
  - GEO
  - GRAPHMAGICK
  - LUA
  - NLS
  - OPENJPEG
  - SQUISH
  - WEBP

The GCC option is now disabled by default, due to the libstdc++/libc++ conflict in FreeBSD 10+ (exiv2 is linked against default C++ stdlib). First I wanted to use ${OSVERSION} to keep it enabled on FreeBSD 8 & 9 only and maybe remove it completely on FreeBSD 10+, but after some discussion on #bsdports, I was convinced to avoid version-dependant options.

COLORD adds a LIB_DEPENDS to graphics/colord, but darktable provides it's own libcolord.so internally (statically linked). The comment in src/CMakeLists.txt explains that libcolord.so in many [Linux] distros is linked against Gtk+3.

GRAPHMAGICK adds a LIB_DEPENDS to graphics/GraphicsMagick13: I used library name with version (libGraphicsMagick.so.14), because it doesn't build with graphics/GraphicsMagick. I didn't try with graphics/GraphicsMagick12.

LUA triggers the build of Lua 5.2 provided in darktable's source, not lang/lua52. The problem is that lang/lua52 doesn't install a pkgconf file, used by darktable's cmake/modules/FindLua52.cmake.

patch-cmake_modules_FindFreetype.cmake is removed because the corresponding CMake module is gone.

patch-src-common-imageio_exr.hh is removed because a better fix (one which works for both FreeBSD and Mac OS X) is committed upstream.

patch-src-external-lua-CMakeLists.txt is added because -ldl in link flags isn't correct/needed on FreeBSD. I forgot to test Lua integration before the release of darktable 1.4...

pkg-plist's diff is large because I preferred to keep the order of "make makeplist". Future updates will be easier. Otherwise, changes are small.

The patch was tested using advices from StageDir wiki page, except the poudriere/tinderbox step.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: