ports/187117: [PATCH] irc/unrealircd: server crash when built with clang

[Jean-Sébastien Pédron]

>Number:         187117
>Category:       ports
>Synopsis:       [PATCH] irc/unrealircd: server crash when built with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 27 17:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jean-Sébastien Pédron
>Release:        10.0-RELEASE
>Organization:
The FreeBSD Project
>Environment:
FreeBSD ns220664.ip-188-165-245.eu 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root at snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
When built with clang, UnrealIRCd fails to start. Here's the bug report open upstream:
http://bugs.unrealircd.org/view.php?id=4239

This bug report proposes a fix to version 3.2.10.1. Based on that, Christopher Faulet prepared an updated patch to irc/unreal 3.2.10.2 port.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: irc/unreal/files/patch-configure
===================================================================
--- irc/unreal/files/patch-configure	(revision 0)
+++ irc/unreal/files/patch-configure	(working copy)
@@ -0,0 +1,20 @@
+--- configure	2014-02-27 14:03:45.132445608 +0100
++++ configure	2014-02-27 14:03:05.502448091 +0100
+@@ -6356,7 +6356,7 @@
+ 
+ 
+ hold_cflags=$CFLAGS
+-CFLAGS="$CFLAGS -export-dynamic"
++CFLAGS="$CFLAGS -Wl,-export-dynamic"
+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking if we need the -export-dynamic flag" >&5
+ $as_echo_n "checking if we need the -export-dynamic flag... " >&6; }
+ if ${ac_cv_export_dynamic+:} false; then :
+@@ -6395,7 +6395,7 @@
+ else
+ 
+ if test "$ac_cv_c_compiler_gnu" = "yes"; then
+-	ac_cv_pic="-fPIC -DPIC -shared"
++	ac_cv_pic="-std=gnu89 -fPIC -DPIC -shared"
+ 	case `uname -s` in
+ 		Darwin*)
+ 		ac_cv_pic="-bundle -flat_namespace -undefined suppress"

Property changes on: irc/unreal/files/patch-configure
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: irc/unreal/files/patch-configure.ac
===================================================================
--- irc/unreal/files/patch-configure.ac	(revision 0)
+++ irc/unreal/files/patch-configure.ac	(working copy)
@@ -0,0 +1,20 @@
+--- configure.ac	2013-11-24 20:24:26.000000000 +0100
++++ configure.ac	2014-02-27 14:02:58.916469490 +0100
+@@ -107,7 +107,7 @@
+ ])])
+ 
+ hold_cflags=$CFLAGS
+-CFLAGS="$CFLAGS -export-dynamic"
++CFLAGS="$CFLAGS -Wl,-export-dynamic"
+ AC_CACHE_CHECK(if we need the -export-dynamic flag, ac_cv_export_dynamic, [
+ AC_TRY_LINK(, [int i];, ac_cv_export_dynamic=yes, ac_cv_export_dynamic=no)])
+ if test "$ac_cv_export_dynamic" = "no"; then
+@@ -116,7 +116,7 @@
+ 
+ AC_CACHE_CHECK(for compiler option to produce PIC,ac_cv_pic,[
+ if test "$ac_cv_prog_gcc" = "yes"; then
+-	ac_cv_pic="-fPIC -DPIC -shared"
++	ac_cv_pic="-std=gnu89 -fPIC -DPIC -shared"
+ 	case `uname -s` in
+ 		Darwin*[)]
+ 		ac_cv_pic="-bundle -flat_namespace -undefined suppress"

Property changes on: irc/unreal/files/patch-configure.ac
___________________________________________________________________
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property


>Release-Note:
>Audit-Trail:
>Unformatted: