ports/186955: [PATCH] Port ftp/curl needs openssl and heimdal dependencies

[Yuri]

>Number:         186955
>Category:       ports
>Synopsis:       [PATCH] Port ftp/curl needs openssl and heimdal dependencies
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 22 06:40:02 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Yuri
>Release:        9.2
>Organization:
n/a
>Environment:
>Description:
Currently curl-7.35.0 depends on /usr/lib/libheimntlm.so.10 from the base system.
This dependency pulls /lib/libcrypto.so.6 which conflicts with openssl-1.0.1_9 package.

The effect of this conflict for me was that command 'git clone https://...' always fails. This is because git-helper-https is linked with libcurl and always gets /lib/libcrypto.so.6 dependency in addition to /usr/local/lib/libcrypto.so.8

The patch attached establishes dependencies on openssl and heimdal from the ports, eliminating potential conflicts with libheimntlm.so and libcrypto.so

Caveat: current security/heimdal has conflict with openssl in manpages. Removing MAN3 from  security/heimdal/Makefile fixed the conflict. (MAN3= after include Makefile.man there)

In general, ports shopuld never link to security libraries from the base system, only to their counterparts from ports, due to such conflicts.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: ftp/curl/Makefile
===================================================================
--- ftp/curl/Makefile	(revision 345565)
+++ ftp/curl/Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	curl
 PORTVERSION=	7.35.0
+PORTREVISION=	1
 CATEGORIES=	ftp www
 MASTER_SITES=	http://curl.haxx.se/download/ \
 		LOCAL/sunpoet
@@ -33,6 +34,7 @@
 CONFIGURE_ENV+=	LOCALBASE=${LOCALBASE}
 GNU_CONFIGURE=	yes
 MAKE_ENV+=	INSTALL_STRIP_FLAG=${STRIP}
+USE_OPENSSL=	yes
 USE_PERL5=	build
 USE_XZ=		yes
 USES=		pathfix perl5
@@ -71,8 +73,8 @@
 GNUTLS_CONFIGURE_ON=	--with-gnutls=${LOCALBASE}
 GNUTLS_LIB_DEPENDS=	libgnutls.so:${PORTSDIR}/security/gnutls
 GSSAPI_CONFIGURE_OFF=	--without-gssapi
-GSSAPI_CONFIGURE_ON=	--with-gssapi=/usr
-GSSAPI_CPPFLAGS=	-I${INCLUDEDIR}/gssapi
+GSSAPI_CONFIGURE_ON=	--with-gssapi=${LOCALBASE}
+GSSAPI_CPPFLAGS=	-I${LOCALBASE}/include/gssapi
 IDN_CONFIGURE_OFF=	--without-libidn
 IDN_CONFIGURE_ON=	--with-libidn=${LOCALBASE}
 IDN_LIB_DEPENDS=	libidn.so:${PORTSDIR}/dns/libidn
@@ -115,6 +117,8 @@
 THREADED_RESOLVER_CONFIGURE_ON=	--enable-threaded-resolver
 TLS_SRP_CONFIGURE_OFF=	--disable-tls-srp
 TLS_SRP_CONFIGURE_ON=	--enable-tls-srp
+BUILD_DEPENDS+=		${LOCALBASE}/lib/libgssapi.so:${PORTSDIR}/security/heimdal
+RUN_DEPENDS+=		${LOCALBASE}/lib/libgssapi.so:${PORTSDIR}/security/heimdal
 
 .include <bsd.port.options.mk>
 


>Release-Note:
>Audit-Trail:
>Unformatted: