ports/186637: convertors/recode doesn't build on FreeBSD 10

[Mark Knight]

>Number:         186637
>Category:       ports
>Synopsis:       convertors/recode doesn't build on FreeBSD 10
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 10 21:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Mark Knight
>Release:        FreeBSD 10.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD shrewd.pub.knigma.org 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r261574: Fri Feb 7 17:06:49 GMT 2014 root at shrewd.pub.knigma.org:/usr/obj/usr/src/sys/SHREWD amd64


	
>Description:
--- libiconv.lo ---
cd /usr/ports/convertors/record on FreeBSD 10 yields:

libtool: compile:  cc -DLIBDIR=\"/usr/local/lib\" -DHAVE_CONFIG_H -I.. -I. -I../lib -I/usr/local/include -I/usr/local/include -DLIBICONV_PLUG -O2 -pipe -fPIC -DLIBICONV_PLUG -fno-strict-aliasing -c libiconv.c  -fPIC -DPIC -o .libs/libiconv.o
libiconv.c:50:3: warning: implicit declaration of function 'iconvctl' is invalid in C99 [-Wimplicit-function-declaration]
  iconvctl (conversion, ICONV_SET_TRANSLITERATE, &transliterate);
  ^
libiconv.c:50:25: error: use of undeclared identifier 'ICONV_SET_TRANSLITERATE'
  iconvctl (conversion, ICONV_SET_TRANSLITERATE, &transliterate);
                        ^
libiconv.c:51:33: error: use of undeclared identifier 'ICONV_SET_TRANSLITERATE'
  iconvctl (conversion_to_utf8, ICONV_SET_TRANSLITERATE, &transliterate);
                                ^
libiconv.c:102:8: error: use of undeclared identifier 'ICONV_SET_TRANSLITERATE'
                            ICONV_SET_TRANSLITERATE, &transliterate);
                            ^
libiconv.c:104:8: error: use of undeclared identifier 'ICONV_SET_TRANSLITERATE'
                            ICONV_SET_TRANSLITERATE, &transliterate);
                            ^
1 warning and 4 errors generated.
*** [libiconv.lo] Error code 1

make[3]: stopped in /usr/ports/converters/recode/work/recode-3.6/src
1 error
>How-To-Repeat:
Not sure if it's related but I have convertors/libiconv installed
per http://svnweb.freebsd.org/ports?view=revision&revision=341775
>Fix:
This patch seems to help but should be checked:

Index: Makefile
===================================================================
--- Makefile    (revision 343581)
+++ Makefile    (working copy)
@@ -11,7 +11,8 @@
 MAINTAINER=    demon at FreeBSD.org
 COMMENT=       Converts files between character sets and usages

-USES=          gettext iconv perl5
+#USES=         gettext iconv perl5
+USES=          gettext iconv:translit perl5
 USE_AUTOTOOLS= libtool
 USE_PERL5=     patch run build
 USE_LDCONFIG=  yes
>Release-Note:
>Audit-Trail:
>Unformatted: