ports/186596: [patch] multimedia/imagination stage support, options helpers

Zsolt Udvari udvzsolt at gmail.com
Sun Feb 9 18:00:01 UTC 2014


>Number:         186596
>Category:       ports
>Synopsis:       [patch] multimedia/imagination stage support, options helpers
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 09 18:00:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Zsolt Udvari
>Release:        FreeBSD 10.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD bsd-zsolt 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root at snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
multimedia/imagination
* supports stage (make DESTDIR works)
* using options helpers
* move sox dependency from BUILD_DEPENDS to LIB_DEPENDS
>How-To-Repeat:
>Fix:

--- imagination.diff begins here ---
diff -ur imagination.orig/Makefile imagination/Makefile
--- imagination.orig/Makefile	2014-02-09 18:42:58.541538953 +0100
+++ imagination/Makefile	2014-02-09 18:37:56.599637677 +0100
@@ -10,8 +10,8 @@
 MAINTAINER=	jessefrgsmith at yahoo.ca
 COMMENT=	DVD slideshow maker
 
+LIB_DEPENDS=libsox.so:${PORTSDIR}/audio/sox
 BUILD_DEPENDS=	${LOCALBASE}/lib/gtk-2.0:${PORTSDIR}/x11-toolkits/gtk20 \
-		${LOCALBASE}/bin/sox:${PORTSDIR}/audio/sox \
 		${LOCALBASE}/bin/intltool-extract:${PORTSDIR}/textproc/intltool
 RUN_DEPENDS=	${LOCALBASE}/bin/ffmpeg:${PORTSDIR}/multimedia/ffmpeg
 
@@ -21,15 +21,10 @@
 
 WRKSRC=	${WRKDIR}/${PORTNAME}-${PORTVERSION}
 
-NO_STAGE=	yes
-.include <bsd.port.options.mk>
+OPTIONS_DEFINE=NLS
 
-.if ${PORT_OPTIONS:MNLS}
-USES+=		gettext
-PLIST_SUB+=	NLS=""
-.else
-CONFIGURE_ARGS+=	--disable-nls
-PLIST_SUB+=	NLS="@comment "
-.endif
+OPTIONS_SUB=yes
+NLS_CONFIGURE_ENABLE=nls
+NLS_USES=gettext
 
 .include <bsd.port.mk>
diff -ur imagination.orig/pkg-plist imagination/pkg-plist
--- imagination.orig/pkg-plist	2014-02-09 18:42:58.541538953 +0100
+++ imagination/pkg-plist	2014-02-09 18:40:49.546582750 +0100
@@ -43,7 +43,6 @@
 share/icons/hicolor/24x24/apps/imagination.png
 share/icons/hicolor/48x48/apps/imagination.png
 share/icons/hicolor/scalable/apps/imagination.svg
-share/icons/hicolor/icon-theme.cache
 %%DATADIR%%/pixmaps/imagination-1.gif
 %%DATADIR%%/pixmaps/imagination-1.png
 %%DATADIR%%/pixmaps/imagination-10.gif
--- imagination.diff ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ports-bugs mailing list