[Bug 192937] [New Port] sysutils/consul

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192937

--- Comment #10 from John Marino <marino at FreeBSD.org> ---
(In reply to Adam Weinberger from comment #5)
> Couple things. Please change the formatting by putting tabs after variables,
> like all the other ports do.
> 
> Second, the COMMENT string is insufficient ("Consul") and the pkg-descr is
> just a marketing blurb.
> 
> Third, you are forcing compilation with clang. FreeBSD supports GCC as well,
> and ccache and distcc. Pass CC="${CC}" if you have to.
> 
> Fourth, install with ${INSTALL_PROGRAM} or ${INSTALL_SCRIPT}, not ${CP}.


Thomas, to be perfectly clear, this PR is on-hold waiting for a new submission
to fix at least the problems Adam mentioned.

-- 
You are receiving this mail because:
You are the assignee for the bug.