[Bug 187280] New port: astro/GeographicLib Library for geographic projections

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187280

--- Comment #12 from John Marino <marino at FreeBSD.org> ---
I don't understand why you did this:

X.if ${PORT_OPTIONS:MGEOID_*}
XDIRRMTRY_DATADIR=    yes
XPLIST_SUB+=    DATA_GEOID=""
XSUB_LIST+=    DATA_GEOID=""
X.else
XPLIST_SUB+=    DATA_GEOID="@comment "
XSUB_LIST+=    DATA_GEOID="@comment "
X.endif
X.if ${PORT_OPTIONS:MGRAVITY_*}
XDIRRMTRY_DATADIR=    yes
XPLIST_SUB+=    DATA_GRAVITY=""
XSUB_LIST+=    DATA_GRAVITY=""
X.else
XPLIST_SUB+=    DATA_GRAVITY="@comment "
XSUB_LIST+=    DATA_GRAVITY="@comment "
X.endif
X.if ${PORT_OPTIONS:MMAGNETIC_*}
XDIRRMTRY_DATADIR=    yes
XPLIST_SUB+=    DATA_MAGNETIC=""
XSUB_LIST+=    DATA_MAGNETIC=""
X.else
XPLIST_SUB+=    DATA_MAGNETIC="@comment "
XSUB_LIST+=    DATA_MAGNETIC="@comment "
X.endif
X.ifdef DIRRMTRY_DATADIR
XPLIST_SUB+=    DIRRMTRY_DATADIR=""
XSUB_LIST+=    DIRRMTRY_DATADIR=""
X.else
XPLIST_SUB+=    DIRRMTRY_DATADIR="@comment "
XSUB_LIST+=    DIRRMTRY_DATADIR="@comment "
X.endif


You have OPTIONS_SUB=yes, so if you pkg-plist used for example %%MAGNETIC%%
instead of %%DATA_MAGNETIC%%, you can delete all the PLIST_SUB lines.

for SUB_LIST, how is "@comment " valid on a non-pkg-plist?  It's a very strange
substition to make.

I'd have to look at DIRRMTRY_DATADIR closer but that smells like a hack.

-- 
You are receiving this mail because:
You are the assignee for the bug.