[Bug 192964] [New Port] devel/go-hashicorp-logutils

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192964

--- Comment #4 from Thomas Bartelmess <thomas at bartelmess.io> ---
For me it seems like 
bsd.port.pre.mk has to be included before bsd.go.mk
If it's not included, I am getting an error, because the $ARCH variable is not
set

   WARNING (devel/go-hashicorp-logutils): make:
"/usr/ports/devel/go-hashicorp-logutils/../../lang/go/files/bsd.go.mk" line 20:
Malformed conditional (${ARCH} == "i386")
   WARNING (devel/go-hashicorp-logutils): make: Fatal errors encountered --
cannot continue


Is there a reason why 

.include "${.CURDIR}/../../lang/go/files/bsd.go.mk"

if preferred over
.include "${PORTSDIR}/lang/go/files/bsd.go.mk"

or is that just convention?

I was the go-sql-driver
(https://svnweb.freebsd.org/ports/head/devel/go-sql-driver/) which is also a go
library.

(In reply to John Marino from comment #3)
> 1) you can just past portlint output in comment, we don't need attachment
> for that
> 
> 2) when you attach a shar, set mime = text/plain
> 
> 3) You tabbed too much, everything except PORTVERSION
> 
> 4) you did this again:
> 
> X.include <bsd.port.pre.mk>
> X.include "${PORTSDIR}/lang/go/files/bsd.go.mk"
> X.include <bsd.port.post.mk>
> 
> 5) see this?
> 
> X at dirrmtry %%GO_SRCDIR%%/%%GO_PKGNAME%%
> X at dirrmtry %%GO_SRCDIR%%/github.com/hashicorp
> X at dirrmtry %%GO_SRCDIR%%/github.com
> X at dirrmtry %%GO_SRCDIR%%
> X at dirrmtry %%GO_LIBDIR%%/github.com/hashicorp
> X at dirrmtry %%GO_LIBDIR%%/github.com
> X at dirrmtry %%GO_LIBDIR%%
> X at dirrmtry share/go/pkg
> X at dirrmtry share/go
> 
> I think only the first one is needed; the rest probably belong to go.  And
> the first one should be @dirrm, not @dirrmtry.  Never use @dirrmtry if
> @dirrm is guaranteed to work.
> 
> Please update the shar.

-- 
You are receiving this mail because:
You are the assignee for the bug.