[Bug 189257] [NEW PORT] databases/percona56-xtradb-cluster

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=189257

--- Comment #16 from John Marino <marino at FreeBSD.org> ---
Scott, this looks real good.

I have only two concerns.

1) on this line:
Xpost-install:
X    @${MKDIR} ${STAGEDIR}/var/db/mysql
X    @${RM} -rf ${STAGEDIR}${PREFIX}/xinetd.d

The "@" on the RM command masks the file removal.  It is against policy to mask
installation steps (with mkdir being the exception so the first line is ok)


2) you have "flo at freebsd.org" being listed as the maintainer.
This is unusual.  Did flo agree to this?  I see on the description 
"I've been talking to flo who's the maintainer of the percona database software
amongst others, he told me to create a PR to get this port committed as he
didn't have time."

That doesn't mean he agreed to maintain the port.

So either somebody else needs to be listed as the maintainer, or flo needs to
explicitly approve this PR and agree to the maintainer.  Do you want me add him
to the PR or should somebody else be the maintainer?

-- 
You are receiving this mail because:
You are the assignee for the bug.