ports/182474: net/tightvnc vncviewer can't handle null authentication

[Peter Jeremy]

>Number:         182474
>Category:       ports
>Synopsis:       net/tightvnc vncviewer can't handle null authentication
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 28 23:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Peter Jeremy
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
n/a
>Environment:
System: FreeBSD aspire.rulingia.com 8.3-STABLE FreeBSD 8.3-STABLE #19: Sun Jan 13 17:55:03 EST 2013     root at builder.rulingia.com:/obj/usr/src/sys/aspire  i386

virtualbox-ose-4.2.18_1
tightvnc-1.3.10_3

>Description:
	vncviewer rejects empty passwords and therefore can't be used with
	VNC sessions that don't require authentication.  Specifically,
	VBoxHeadless with the default null authentication still triggers
	vncviewer to request a password but vncviewer rejects an empty
	password.

	See also PR ports/182471

>How-To-Repeat:

	$ vncviewer server:6213
Connected to RFB server, using protocol version 3.8
Performing standard VNC authentication
Password: 
Reading password failed


>Fix:

	The following patch allows empty passwords to be entered.
--- vncviewer/rfbproto.c~	2006-12-08 18:20:03.000000000 +1100
+++ vncviewer/rfbproto.c	2013-09-29 09:19:34.782746129 +1000
@@ -569,7 +569,7 @@
     passwd = getpass("Password: ");
   }
 
-  if (!passwd || strlen(passwd) == 0) {
+  if (!passwd) {
     fprintf(stderr, "Reading password failed\n");
     return False;
   }

>Release-Note:
>Audit-Trail:
>Unformatted: