ports/182453: Port databases/riak does not create the directory in /usr/local

[Kenji Rikitake]

>Number:         182453
>Category:       ports
>Synopsis:       Port databases/riak does not create the directory in /usr/local
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 28 03:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Kenji Rikitake
>Release:        9.2-PRERELEASE
>Organization:
>Environment:
FreeBSD wellmax.priv.k2r.org 9.2-PRERELEASE FreeBSD 9.2-PRERELEASE #11 r255623: Tue Sep 17 17:02:32 JST 2013     root at wellmax.priv.k2r.org:/usr/obj/usr/src/sys/K2RKERNEL  amd64
>Description:
The Port creates the following three spurious directories
/etc/riak /lib/riak/lib /lib/riak
instead of
/usr/local/etc/riak /usr/local/lib/riak/lib /usr/local/lib/riak
during `make install`, and the install procedures abnormally terminated.

My investigation suggests that the ".for" statement in the target "do-install" in the Makefile does not function properly.
>How-To-Repeat:
(cd /usr/ports/databases/riak && make && make install)
>Fix:
Apply the patch in this PR.
(The .for loop in the Makefile is manually expanded;
this patch will not add unnecessary complexity
because the .for loop only handles five directories)

Patch attached with submission follows:

--- Makefile.orig	2013-09-27 21:04:42.000000000 +0900
+++ Makefile	2013-09-28 11:54:08.000000000 +0900
@@ -64,9 +64,11 @@
 	${ECHO} "@dirrmtry %%RIAK_LOGDIR%%" >> ${PLIST}
 
 do-install:
-.for d in ${RIAK_CONFDIR} ${RIAK_LOGDIR} ${RIAK_DBDIR} ${RIAK_LIBDIR} ${RIAK_HOMEDIR}
-	[ -d ${d} ] || ${MKDIR} ${d} && ${CHOWN} ${USERS}:${GROUPS} ${d}
-.endfor
+	${MKDIR} ${RIAK_CONFDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_CONFDIR}
+	${MKDIR} ${RIAK_LOGDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_LOGDIR}
+	${MKDIR} ${RIAK_DBDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_DBDIR}
+	${MKDIR} ${RIAK_LIBDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_LIBDIR}
+	${MKDIR} ${RIAK_HOMEDIR} && ${CHOWN} ${USERS}:${GROUPS} ${RIAK_HOMEDIR}
 	${INSTALL_DATA} ${WRKSRC}/rel/riak/etc/vm.args ${RIAK_CONFDIR}/vm.args.sample
 	${INSTALL_DATA} ${WRKSRC}/rel/riak/etc/app.config ${RIAK_CONFDIR}/app.config.sample
 	${INSTALL_DATA} ${WRKSRC}/rel/riak/etc/cert.pem ${RIAK_CONFDIR}/cert.pem.sample


>Release-Note:
>Audit-Trail:
>Unformatted: