ports/182131: [patch] www/redmine: multiple small errors

[David Demelier]

>Number:         182131
>Category:       ports
>Synopsis:       [patch] www/redmine: multiple small errors
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 15 21:30:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     David Demelier
>Release:        FreeBSD 9.2-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD Melon 9.2-PRERELEASE FreeBSD 9.2-PRERELEASE #1 r254536M: Mon Aug 19 23:10:30 CEST 2013 root at Melon:/usr/obj/usr/src/sys/GENERIC amd64

>Description:

The current version of redmine has a lot of problems. A default installation of
the port will not allow the user to run the service directly because:

  1. Redmine *requires* LDAP, you can't disable it at all. So I remove the
     option so it starts.

  2. Someone did update the coderay plugin without updating redmine, which
     led to not found exception.

  3. Redmine will use ${WWWDIR}/pids/ directory by default and it's not
     writable by redmine after a clean install. This is also fixed.

>How-To-Repeat:

Install redmine, you can't start it even after configuring the database.yml

>Fix:

--- redmine.diff begins here ---
--- Makefile.orig	2013-09-15 22:52:16.000000000 +0200
+++ Makefile	2013-09-15 23:05:10.000000000 +0200
@@ -18,7 +18,8 @@
 		rubygem-rack-openid>=0:${PORTSDIR}/www/rubygem-rack-openid \
 		rubygem-coderay>=1.0.9:${PORTSDIR}/textproc/rubygem-coderay \
 		rubygem-fastercsv>=1.5.0:${PORTSDIR}/devel/rubygem-fastercsv \
-		rubygem-builder>=3.0.0:${PORTSDIR}/devel/rubygem-builder
+		rubygem-builder>=3.0.0:${PORTSDIR}/devel/rubygem-builder \
+		rubygem-net-ldap>=0.3.1:${PORTSDIR}/net/rubygem-net-ldap
 
 USE_RUBY=	yes
 USE_RUBY_FEATURES=	iconv
@@ -26,7 +27,7 @@
 NO_BUILD=	yes
 SUB_LIST+=	RUBY_NAME=${RUBY_NAME}
 
-OPTIONS_DEFINE=	MYSQL MYSQL2 POSTGRESQL RMAGIC WWWSERVER LDAP
+OPTIONS_DEFINE=	MYSQL MYSQL2 POSTGRESQL RMAGIC WWWSERVER
 OPTIONS_DEFAULT=MYSQL2 RMAGIC WWWSERVER THIN
 OPTIONS_SINGLE=	WWWSERVER
 OPTIONS_SINGLE_WWWSERVER=	THIN PASSENGER
@@ -71,10 +72,6 @@
 .endif
 .endif
 
-.if ${PORT_OPTIONS:MLDAP}
-RUN_DEPENDS+=	rubygem-net-ldap>=0.3.1:${PORTSDIR}/net/rubygem-net-ldap
-.endif
-
 post-extract:
 	${MV} ${WRKSRC}/config/settings.yml ${WRKSRC}/config/settings.yml-dist
 
@@ -83,11 +80,15 @@
 
 do-install:
 	${MKDIR} ${WWWDIR}
+	${MKDIR} ${WWWDIR}/tmp/pids
 	cd ${WRKSRC} && \
 	${COPYTREE_SHARE} "*" ${WWWDIR} "! ( -name *\.orig -o -name *\.bak )"
 	${FIND} ${WRKSRC}/script -type f -print | ${XARGS} ${CHMOD} 755
 
 post-install:
+	${TOUCH} ${WWWDIR}/Gemfile.lock
+	${CHOWN} ${WWWOWN}:${WWWGRP} ${WWWDIR}/Gemfile.lock
+	
 	if ! [ -r ${WWWDIR}/config/settings.yml ]; then			\
 		${INSTALL_DATA} ${WWWDIR}/config/settings.yml-dist	\
 			${WWWDIR}/config/settings.yml;			\
--- files/patch-Gemfile.orig	2013-09-15 22:54:28.000000000 +0200
+++ files/patch-Gemfile	2013-09-15 22:54:49.000000000 +0200
@@ -1,5 +1,5 @@
---- Gemfile.orig	2013-07-14 16:51:09.000000000 +0000
-+++ Gemfile	2013-07-21 12:56:04.025404096 +0000
+--- Gemfile.orig	2013-07-14 18:51:09.000000000 +0200
++++ Gemfile	2013-09-15 22:53:56.000000000 +0200
 @@ -1,11 +1,11 @@
  source 'https://rubygems.org'
  
@@ -7,7 +7,8 @@
 -gem "jquery-rails", "~> 2.0.2"
 +gem "jquery-rails", "~> 3.0"
  gem "i18n", "~> 0.6.0"
- gem "coderay", "~> 1.0.9"
+-gem "coderay", "~> 1.0.9"
++gem "coderay", "~> 1.1.0"
  gem "fastercsv", "~> 1.5.0", :platforms => [:mri_18, :mingw_18, :jruby]
 -gem "builder", "3.0.0"
 +gem "builder", "~> 3.0.0"
--- redmine.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: