ports/181897: multimedia/ffmpeg1 fails to configure if ICONV option is disabled

[John Baldwin]

>Number:         181897
>Category:       ports
>Synopsis:       multimedia/ffmpeg1 fails to configure if ICONV option is disabled
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 06 19:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     John Baldwin
>Release:        HEAD
>Organization:
>Environment:
>Description:
The makefile for this port has a typo in the argument passed to ./configure if ICONV is disabled (it is enabled by default).  If you disable it, configure fails with:

===>  Configuring for ffmpeg1-1.2.3
===>   FreeBSD 10 autotools fix applied to /usr/ports/multimedia/ffmpeg1/work/ffmpeg-1.2.3/configure
Unknown option "--disable-libiconv".

>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
--- Makefile    (revision 326408)
+++ Makefile    (working copy)
@@ -275,7 +275,7 @@
 USES+= iconv
 CONFIGURE_ARGS+=       --enable-iconv
 .else
-CONFIGURE_ARGS+=       --disable-libiconv
+CONFIGURE_ARGS+=       --disable-iconv
 .endif
 
 # lame


>Release-Note:
>Audit-Trail:
>Unformatted: