ports/181838: [patch] x11-servers/xorg-server: fix TLS variables with clang

Tijl Coosemans tijl at FreeBSD.org
Thu Sep 5 14:20:02 UTC 2013


>Number:         181838
>Category:       ports
>Synopsis:       [patch] x11-servers/xorg-server: fix TLS variables with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 05 14:20:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Tijl Coosemans
>Release:        FreeBSD 10.0-CURRENT i386
>Organization:
>Environment:
>Description:
The configure test to find out how to declare thread local variables
is currently broken with clang because it accepts __declspec(thread)
eventhough it doesn't work.  So variables that are supposed to be
thread-local are currently global.  The attached patch adds
ac_cv_tls=__thread to CONFIGURE_ARGS.
>How-To-Repeat:
>Fix:

--- xorg-server.patch begins here ---
Index: x11-servers/xorg-server/Makefile
===================================================================
--- x11-servers/xorg-server/Makefile	(revision 326283)
+++ x11-servers/xorg-server/Makefile	(working copy)
@@ -22,7 +22,7 @@ SLAVE_PORT?=	no
 
 .if defined(WITH_NEW_XORG)
 XORG_VERSION=	1.12.4
-XORG_REVISION=	1
+XORG_REVISION=	2
 PLIST_SUB+=	OLD="@comment " NEW=""
 EXTRA_PATCHES+=	${FILESDIR}/extra-clang
 .else
@@ -58,6 +58,7 @@ CONFIGURE_ARGS?=--disable-dmx --disable-
 		--without-xmlto --disable-docs --disable-devel-docs \
 		--localstatedir=/var --without-dtrace --disable-xephyr \
 		--enable-record=yes
+CONFIGURE_ARGS+=ac_cv_tls=__thread
 
 .if ${SLAVE_PORT} == "no"
 SUB_FILES=	pkg-install pkg-deinstall
--- xorg-server.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ports-bugs mailing list