ports/181719: [PATCH] multimedia/ffmpeg1 build fails when iconv option is off

[Roland Smith]

>Number:         181719
>Category:       ports
>Synopsis:       [PATCH] multimedia/ffmpeg1 build fails when iconv option is off
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 01 10:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Roland Smith
>Release:        FreeBSD 9.1-RELEASE-p4 amd64
>Organization:
>Environment:
System: FreeBSD slackbox.erewhon.net 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0 r252106: Sun Jun 23 13:52:06 CEST 2013 root at slackbox.erewhon.net:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:

The build of multimedia/ffmpeg1 fails when the ICONV option (ON by default) is
switched off:

===>  Cleaning for ffmpeg1-1.2.3
===>  License GPLv2 LGPL21 accepted by the user
===>  Found saved configuration for ffmpeg1-1.2.1
===> Fetching all distfiles required by ffmpeg1-1.2.3 for building
===>  Extracting for ffmpeg1-1.2.3
=> SHA256 Checksum OK for ffmpeg-1.2.3.tar.bz2.
===>  Patching for ffmpeg1-1.2.3
===>  Applying FreeBSD patches for ffmpeg1-1.2.3
===>   ffmpeg1-1.2.3 depends on executable: yasm - found
===>   ffmpeg1-1.2.3 depends on file: /usr/local/bin/as - found
===>   ffmpeg1-1.2.3 depends on executable: texi2html - found
===>   ffmpeg1-1.2.3 depends on executable: pkgconf - found
===>   ffmpeg1-1.2.3 depends on executable: gmake - found
===>   ffmpeg1-1.2.3 depends on file: /usr/local/bin/perl5.16.3 - found
===>   ffmpeg1-1.2.3 depends on shared library: fontconfig - found
===>   ffmpeg1-1.2.3 depends on shared library: freetype - found
===>   ffmpeg1-1.2.3 depends on shared library: mp3lame - found
===>   ffmpeg1-1.2.3 depends on shared library: schroedinger-1.0.11 - found
===>   ffmpeg1-1.2.3 depends on shared library: theora - found
===>   ffmpeg1-1.2.3 depends on shared library: vorbisenc - found
===>   ffmpeg1-1.2.3 depends on shared library: x264 - found
===>  Configuring for ffmpeg1-1.2.3
Unknown option "--disable-libiconv".
See ./configure --help for available options.
===>  Script "configure" failed unexpectedly.
Please report the problem to mm at FreeBSD.org [maintainer] and attach the
"/usr/ports/multimedia/ffmpeg1/work/ffmpeg-1.2.3/config.err" including the
output of the failure of your make command. Also, it might be a good idea to
provide an overview of all packages installed on your system (e.g. a
/usr/sbin/pkg_info -Ea).
*** [do-configure] Error code 1

Stop in /usr/ports/multimedia/ffmpeg1.
*** [build] Error code 1

Stop in /usr/ports/multimedia/ffmpeg1.

According to the output of "configure --help", it should be "--disable-iconv"
instead of "--disable-libiconv":

    External library support:
    --enable-avisynth        enable reading of AVISynth script files [no]
    --disable-bzlib          disable bzlib [autodetect]
    --enable-fontconfig      enable fontconfig
    --enable-frei0r          enable frei0r video filtering
    --enable-gnutls          enable gnutls [no]
    --disable-iconv          disable iconv [autodetect]

>How-To-Repeat:

Build multimedia/ffmpeg1 fails when the ICONV option set to OFF.

>Fix:

Apply the following patch to the port Makefile:

---------- /usr/ports/multimedia/ffmpeg1/Makefile patch ----------
--- Makefile.orig       2013-09-01 11:34:42.000000000 +0200
+++ Makefile    2013-09-01 11:35:32.000000000 +0200
@@ -275,7 +275,7 @@
 USES+= iconv
 CONFIGURE_ARGS+=       --enable-iconv
 .else
-CONFIGURE_ARGS+=       --disable-libiconv
+CONFIGURE_ARGS+=       --disable-iconv
 .endif
 
 # lame
---------- /usr/ports/multimedia/ffmpeg1/Makefile patch ----------


>Release-Note:
>Audit-Trail:
>Unformatted: