ports/183219: multimedia/rtmpdump won't work

[higemaniya]

>Number:         183219
>Category:       ports
>Synopsis:       multimedia/rtmpdump won't work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 23 05:30:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     higemaniya
>Release:        9.1-RELEASE-p7
>Organization:
>Environment:
FreeBSD localhost.localdomain 9.1-RELEASE-p7 FreeBSD 9.1-RELEASE-p7 #0: Mon Sep  9 21:34:37 UTC 2013     root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
I can build rtmpdump-2.4.20130923 without error but it won't work:

RTMPDump v2.4
(c) 2010 Andrej Stepanchuk, Howard Chu, The Flvstreamer Team; license: GPL
WARNING: No application or playpath in URL!
WARNING: Ignoring SWF hash, supply also the swf size  with --swfsize
Connecting ...
Assertion failed: (digestLen == 32), function HMACsha256, file handshake.h, line 275.
Abort trap (core dumped)


I have also noticed that rtmpdump-2.4.20130923 build with old rtmpdump-2.4 package installed result build error. pkg_delete rtmpdump will work for this.


Regards,
>How-To-Repeat:

>Fix:
This patch fixes the probrem for me:

diff -ru a/rtmpdump/files/patch-librtmp-Makefile b/rtmpdump/files/patch-librtmp-Makefile
--- a/rtmpdump/files/patch-librtmp-Makefile        2013-10-17 10:06:58.000000000 +0900
+++ b/rtmpdump/files/patch-librtmp-Makefile        2013-10-23 13:32:38.239412227 +0900
@@ -49,7 +49,7 @@
  OPT=-O2
 -CFLAGS=-Wall $(XCFLAGS) $(INC) $(DEF) $(OPT) $(SO_DEF)
 +#CFLAGS=-Wall $(XCFLAGS) $(INC) $(DEF) $(OPT) $(SO_DEF)
-+CFLAGS=$(DEF) $(OPT) $(SO_DEF)
++CFLAGS+=$(DEF) $(OPT) $(SO_DEF)
  LDFLAGS=$(XLDFLAGS)


>Release-Note:
>Audit-Trail:
>Unformatted: