ports/182717: ports: www/fcgiwrap building broken, dependency on devel/pkgconf missing

[Phillip Jaenke]

>Number:         182717
>Category:       ports
>Synopsis:       ports: www/fcgiwrap building broken, dependency on devel/pkgconf missing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 05 20:50:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Phillip Jaenke
>Release:        9.2-RELEASE
>Organization:
>Environment:
FreeBSD teldrassil 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013     root at bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Reproduced on several machines and jails independently, discovered in local poudriere builds. 

The problem is two-fold. On the first go-round, it appears that fcgiwrap is not running aclocal before autoconf.

===>  Configuring for fcgiwrap-1.1.0
configure.ac:32: error: possibly undefined macro: AC_DEFINE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

Manually running aclocal resolves this issue - why this is, I don't know. aclocal is indicated in USE_AUTOTOOLS. 

However, there is another issue independent of aclocal not running first. It is missing the dependency on pkgconf. So after aclocal run is resolved, the resulting output is this:

checking for cc option to accept ISO C89... none needed
./configure: PKG_PROG_PKG_CONFIG: not found
checking for FCGX_Init in -lfcgi... yes
./configure: 3018: Syntax error: word unexpected (expecting ")")
===>  Script "configure" failed unexpectedly.
Please report the problem to ports at FreeBSD.org [maintainer] and attach the
"/usr/ports/www/fcgiwrap/work/gnosek-fcgiwrap-333ff99/config.log" including
the output of the failure of your make command. Also, it might be a good idea
to provide an overview of all packages installed on your system (e.g. a
/usr/sbin/pkg_info -Ea).
*** [do-configure] Error code 1

>How-To-Repeat:
Attempt to build current fcgiwrap without pkgconf already installed.
>Fix:
I suspect aclocal is bombing due to missing pkgconf, but not 100% certain of it. The following one-line fix to www/fcgiwrap/Makefile fixes it on my systems, but I don't know that it follows best practices. (The actual file it appears to need is ${LOCALBASE}/share/aclocal/pkg.m4)

BUILD_DEPENDS=       pkgconf:${PORTSDIR}/devel/pkgconf

>Release-Note:
>Audit-Trail:
>Unformatted: