ports/183836: Update audio/flac for OGG as option [PATCH]

[Horia Racoviceanu]

>Number:         183836
>Category:       ports
>Synopsis:       Update audio/flac for OGG as option [PATCH]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 10 09:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Horia Racoviceanu
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
>Environment:
FreeBSD horia.lan 9.1-RELEASE-p7 FreeBSD 9.1-RELEASE-p7 #0: Mon Sep  9 21:34:37 UTC 2013 root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Add ogg depend as option in audio/flac.
Unfortunately, the configure script does not handle
--without-ogg, so unchecking the OGG option with ogg
installed will lead to a hidden dependency, but at
least people who don't have+want ogg installed will
be able to avoid it.


>How-To-Repeat:

>Fix:
- Add ogg in OPTIONS
- Move LIB_DEPENDS to OGG_LIB_DEPENDS
- Move ogg CONFIGURE_ARGS to OGG_CONFIGURE_ON
CONFIGURE_ON is used because the configure script
does not like --without-ogg="${LOCALBASE}", that
CONFIGURE_WITH would generate with OGG=off.

Build log:
https://redports.org/buildarchive/20131110075236-89415/

Patch attached with submission follows:

diff -ruN flac-org/Makefile flac/Makefile
--- flac-org/Makefile	2013-09-24 17:39:26.000000000 -0400
+++ flac/Makefile	2013-11-10 02:35:50.000000000 -0500
@@ -10,27 +10,27 @@
 MAINTAINER=	naddy at FreeBSD.org
 COMMENT=	Free lossless audio codec
 
-LIB_DEPENDS=	libogg.so:${PORTSDIR}/audio/libogg
-
 USES=		pathfix pkgconfig
 USE_AUTOTOOLS=	libtool
 USE_LDCONFIG=	yes
 USE_XZ=		yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--enable-sse \
-		--with-ogg="${LOCALBASE}" \
 		--disable-silent-rules \
 		--disable-thorough-tests \
 		--disable-xmms-plugin
 
-OPTIONS_DEFINE=	DOCS ICONV
-OPTIONS_DEFAULT=ICONV
+OPTIONS_DEFINE=	DOCS ICONV OGG
+OPTIONS_DEFAULT=ICONV OGG
 
 ICONV_USES=	iconv
 ICONV_CPPFLAGS=	-I${ICONV_PREFIX}/include
 ICONV_LDFLAGS=	-L${ICONV_PREFIX}/lib
 ICONV_CONFIGURE_OFF=	am_cv_func_iconv=no
 
+OGG_CONFIGURE_ON=	--with-ogg="${LOCALBASE}"
+OGG_LIB_DEPENDS=	libogg.so:${PORTSDIR}/audio/libogg
+
 .include <bsd.port.options.mk>
 
 .if ${ARCH} == "i386"


>Release-Note:
>Audit-Trail:
>Unformatted: