ports/183586: [patch] vlc 2.1.0 port requires pulse, works fine with oss, too

[Peter Wullinger]

>Number:         183586
>Category:       ports
>Synopsis:       [patch] vlc 2.1.0 port requires pulse, works fine with oss, too
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 02 09:20:03 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Peter Wullinger
>Release:        9.2-STABLE
>Organization:
>Environment:
FreeBSD kaliope.home 9.2-STABLE FreeBSD 9.2-STABLE #34 r255964M: Tue Oct  1 12:12:55 CEST 2013     src at kaliope.home:/usr/obj/usr/src/sys/KALIOPE_MONO  amd64

>Description:
Since the update to 2.1.0 The multimedia/vlc port now requires pulseaudio.

The relevant commit states

- Disable OSS (it is broken in vlc 2.1.0 and FreeBSD #9760)

This may as well be true, but the port still works perfectly
on older versions of FreeBSD.

I'd suggest either making this change dependent on the installed
FreeBSD version or making pulseaudio the default with OSS still
being an option (even though I do not like that option either).
>How-To-Repeat:
Install port multimedia/vlc

# cd /usr/ports/multimedia/vlc
# make install
>Fix:
Apply the attached patch and rebuild multimedia/vlc

# cd /usr/ports/multimedia/vlc
# make && make deinstall reinstall


Patch attached with submission follows:

--- Makefile.orig	2013-11-01 08:03:19.101369627 +0100
+++ Makefile	2013-11-01 08:27:54.321389004 +0100
@@ -17,8 +17,7 @@
 
 LIB_DEPENDS=	libgcrypt.so:${PORTSDIR}/security/libgcrypt \
 		libproxy.so:${PORTSDIR}/net/libproxy \
-		libdvbpsi.so:${PORTSDIR}/multimedia/libdvbpsi \
-		libpulse.so:${PORTSDIR}/audio/pulseaudio
+		libdvbpsi.so:${PORTSDIR}/multimedia/libdvbpsi
 BUILD_DEPENDS=	ffmpeg>=2.0:${PORTSDIR}/multimedia/ffmpeg
 RUN_DEPENDS=	ffmpeg>=2.0:${PORTSDIR}/multimedia/ffmpeg
 
@@ -30,7 +29,8 @@
 		SAMBA SCHROED SDL SHOUTCAST SKINS STREAM SPEEX SVG \
 		TAGLIB THEORA TWOLAME UPNP V4L VAAPI VCD VORBIS \
 		X11 X264 ZVBI SERVER_ONLY DEBUG \
-		GME NO_DVD LIBBLURAY SAMPLERATE SIDPLAY
+		GME NO_DVD LIBBLURAY SAMPLERATE SIDPLAY \
+		PULSE
 OPTIONS_DEFAULT=A52 AVAHI DBUS DTS DVDREAD DVDNAV FAAD FLAC GNUTLS \
 		HTTPD LUA MAD MATROSKA MPEG2 OGG OPUS PNG QT4 REALAUDIO \
 		SDL SKINS STREAM SPEEX TAGLIB THEORA TWOLAME V4L \
@@ -59,6 +59,7 @@
 ZVBI_DESC=	VBI decoding support
 SERVER_ONLY_DESC=	Only build server parts
 NO_DVD_DESC=	disable DVD specific features
+PULSE_DESC=	use pulseaudio
 
 QT4_CONFIGURE_ENABLE=	qt
 
@@ -182,8 +183,8 @@
 PNG_LIB_DEPENDS=	libpng15.so:${PORTSDIR}/graphics/png
 PNG_CONFIGURE_ENABLE=	png
 
-#PULSEAUDIO_LIB_DEPENDS=	libpulse.so:${PORTSDIR}/audio/pulseaudio
-#PULSEAUDIO_CONFIGURE_ENABLE=	pulse
+PULSEAUDIO_LIB_DEPENDS=	libpulse.so:${PORTSDIR}/audio/pulseaudio
+PULSEAUDIO_CONFIGURE_ENABLE=	pulse
 
 REALAUDIO_CONFIGURE_ENABLE=	realrtsp
 
@@ -258,17 +259,17 @@
 CONFIGURE_ARGS+=	--enable-vlc \
 			--enable-avcodec \
 			--enable-avformat \
+			--enable-oss \
 			--enable-postproc \
-			--enable-pulse \
 			--enable-sftp \
 			--enable-libgcrypt \
 			--disable-alsa \
 			--disable-dc1394 \
 			--disable-directfb \
-			--disable-oss \
 			--disable-projectm \
 			--disable-telx \
 			--disable-tremor \
+			--disable-libvnc \
 			--disable-udev \
 			--disable-update-check
 


>Release-Note:
>Audit-Trail:
>Unformatted: