ports/178954: converters/iconv fails to build with perl5.16

[Dan McGregor]

>Number:         178954
>Category:       ports
>Synopsis:       converters/iconv fails to build with perl5.16
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 24 17:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Dan McGregor
>Release:        9.1-STABLE
>Organization:
>Environment:
FreeBSD shadrach.dyndns.org 9.1-STABLE FreeBSD 9.1-STABLE #4 r250634: Tue May 14 12:14:45 CST 2013     dan at shadrach.dyndns.org:/usr/obj/usr/src/sys/SHADRACH  amd64
>Description:
The port converters/iconv fails to build using perl 5.16. The reason is that perl5.16 removed the getopts.pl file from perl4, after having been deprecated in 5.14.
>How-To-Repeat:
Switch to perl 5.16, and try to build converters/iconv. You will see output like this:

cat /wrkdirs/usr/ports/converters/iconv/work/iconv-2.0/lib/../ccs/charset.aliases /wrkdirs/usr/ports/converters/iconv/work/iconv-2.0/lib/../ces/charset.aliases | /wrkdirs/usr/ports/converters/iconv/work/iconv-2.0/lib/../iconv_builtin    PIC  > aliases.h
Can't locate getopts.pl in @INC (@INC contains: /usr/local/lib/perl5/5.16.2/BSDPAN /usr/local/lib/perl5/site_perl/5.16.2/mach /usr/local/lib/perl5/site_perl/5.16.2 /usr/local/lib/perl5/5.16.2/mach /usr/local/lib/perl5/5.16.2 .) at /wrkdirs/usr/ports/converters/iconv/work/iconv-2.0/lib/../iconv_builtin line 34.
*** [aliases.h] Error code 2

>Fix:
The included patch for converters/iconv/files fixes the problem by patching the affected files to use Getopts::Std instead of getopts.pl.

Patch attached with submission follows:

--- iconv_builtin.orig	2000-11-20 16:07:41.000000000 -0600
+++ iconv_builtin	2013-05-24 10:19:34.765696802 -0600
@@ -31,9 +31,9 @@
 #       iconv (Charset Conversion Library) v2.0
 #
 
-require 'getopts.pl';
+use Getopt::Std;
 
-&Getopts('mno:s:');
+getopts('mno:s:');
 
 if ($opt_o) {
         open(STDOUT, ">$opt_o");
--- ccs/iconv_mktbl.orig	2000-11-18 15:44:27.000000000 -0600
+++ ccs/iconv_mktbl	2013-05-24 10:43:06.598689960 -0600
@@ -31,7 +31,7 @@
 # 	iconv (Charset Conversion Library) v2.0
 #
 
-require 'getopts.pl';
+use Getopt::Std;
 use integer;
 
 sub pack_hex {
@@ -144,7 +144,7 @@
 $opt_p = '0x';
 $opt_u = 1;
 
-&Getopts('aCc:Mm:o:p:u:');
+getopts('aCc:Mm:o:p:u:');
 #         ||| || | | +- u N:	field number for Unicode character codes
 #         ||| || | +--- p str:	prefix
 #         ||| || +----- o file:	output file name


>Release-Note:
>Audit-Trail:
>Unformatted: