ports/178733: devel/ode: make: "/usr/ports/devel/ode/Makefile" line 37: Malformed conditional (${PORT_OPTIONS:MGIMPACT) && defined(WITH_DOUBLE})

[O. Hartmann]

>Number:         178733
>Category:       ports
>Synopsis:       devel/ode: make: "/usr/ports/devel/ode/Makefile" line 37: Malformed conditional (${PORT_OPTIONS:MGIMPACT) && defined(WITH_DOUBLE})
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 18 09:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     O. Hartmann
>Release:        FreeBSD 10.0-CURRENT/amd64
>Organization:
FU Berlin
>Environment:
>Description:
There is a typo in the Makefile preventing the port from being compiled:

make: Unknown modifier ')'
make: "/usr/ports/devel/ode.orig/Makefile" line 37: Malformed conditional (${PORT_OPTIONS:MGIMPACT) && defined(WITH_DOUBLE})
make: Fatal errors encountered -- cannot continue

>How-To-Repeat:
Try to make devel/ode
>Fix:
Correct the malformed line 37 in the Makefile and replace it by:

.if ${PORT_OPTIONS:MGIMPACT} && defined(WITH_DOUBLE)


By the way, a funny permutation of the braces ;-)

Patch attached with submission follows:

diff -Nur ode.orig/Makefile ode/Makefile
--- ode.orig/Makefile	2013-05-18 11:30:01.000000000 +0200
+++ ode/Makefile	2013-05-18 11:32:03.000000000 +0200
@@ -34,7 +34,7 @@
 CFLAGS+=	-fPIC -DPIC
 .endif
 
-.if ${PORT_OPTIONS:MGIMPACT) && defined(WITH_DOUBLE}
+.if ${PORT_OPTIONS:MGIMPACT} && defined(WITH_DOUBLE)
 IGNORE=	currently double precision is not supported by gimpact
 .endif
 


>Release-Note:
>Audit-Trail:
>Unformatted: