ports/178607: net/samba36 has improper conditional dependencies

[Garrett Wollman]

>Number:         178607
>Category:       ports
>Synopsis:       net/samba36 has improper conditional dependencies
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 14 00:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Garrett Wollman
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
MIT Computer Science and Artificial Intelligence Laboratory
>Environment:
System: FreeBSD khavrinen.csail.mit.edu 9.1-RELEASE FreeBSD 9.1-RELEASE #15 r245182: Tue Jan 8 18:09:56 EST 2013 wollman at khavrinen.csail.mit.edu:/usr/obj/usr/src/sys/KHAVRINEN amd64

>Description:

The net/samba36 port has dependencies (on Kerberos libraries) that are
only recorded if the depended-upon implementation is already
installed.  This causes builds in a clean environment (e.g.,
poudriere) to pull in the wrong implementation as a dependency.

>How-To-Repeat:

Configure the poudriere jail's make.conf with:
	KRB5_IMPL=mit
	KRB5_HOME=/usr/local

Run
	poudriere testport -o net/samba36
and see that it pulls in Heimdal as a dependency when MIT Kerberos is
required.

>Fix:

Probably should use optionsng to select the implementation, rather
than inspecting files, like security/openssh-portable does.  I haven't
tested this (it was enough to hand-hack the makefile).
>Release-Note:
>Audit-Trail:
>Unformatted: