ports/178505: [maintainer update] for graphics/openimageio
Raphael Kubo da Costa
rakuco at FreeBSD.org
Sun May 12 08:30:01 UTC 2013
The following reply was made to PR ports/178505; it has been noted by GNATS.
From: Raphael Kubo da Costa <rakuco at FreeBSD.org>
To: Shane Ambler <FreeBSD at ShaneWare.Biz>
Cc: bug-followup at FreeBSD.org
Subject: Re: ports/178505: [maintainer update] for graphics/openimageio
Date: Sun, 12 May 2013 11:24:03 +0300
Shane Ambler <FreeBSD at ShaneWare.Biz> writes:
> On 12/05/2013 06:38, Raphael Kubo da Costa wrote:
>> Is the change to thread.h supposed to work on non-amd64 FreeBSD? Has
>> the patch been sent upstream?
>
> Short - yes and yes.
>
> Long -
> The patch originated with the discovery that i386 version crashed
> using tbb. The addition of arch=i586 to cflags enabled the use of gcc
> atomics. This was merged into the cmake files
> (src/cmake/platform.cmake) in 1.1.6 and taken out of the port
> makefile.
>
> 1.1.6 also included the removal of the freebsd condition in thread.h
> and by Larry Gritz's choice it was replaced with a test that left gcc
> atomics off if tbb was turned on. Disabling gcc atomics when tbb is on
> turned out to be a performance hit and 1.1.7 replaced the freebsd
> condition instead of removing the tbb test.
>
> I have submitted an issue for it (instead of a pull request) which
> seems to be the slow way of getting a change. While 1.1.8 appeared to
> be cli tools fixes and 1.1.9 was only docs, I don't want to drop
> behind so updating here with the patch.
Alright, thanks a lot for the clarification.
More information about the freebsd-ports-bugs
mailing list