ports/178274: [patch] audio/musicpd : add MDNSRESDPONDER port option

Matthieu Volat mazhe at alkumuna.eu
Wed May 1 06:40:01 UTC 2013


>Number:         178274
>Category:       ports
>Synopsis:       [patch] audio/musicpd : add MDNSRESDPONDER port option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 01 06:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Matthieu Volat
>Release:        9.1-RELEASE
>Organization:
>Environment:
FreeBSD freedom.alkumuna.eu 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root at farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
audio/musicpd port is only allowing to enable Avahi support while mDNSResponder support is possible in mpd, and only one option away.

Could it be added? I've attached a patch for the port Makefile.
>How-To-Repeat:
cd /usr/ports/audio/musicpd && make config
-> only avahi option
>Fix:
apply/adapt provided patch to provide a radio choice for zeroconf support and allows to use mDNSResponder as choice of implementation.

Patch attached with submission follows:

diff -ru Makefile.orig Makefile
--- Makefile.orig	2013-04-30 22:48:02.000000000 +0200
+++ Makefile	2013-05-01 08:27:47.000000000 +0200
@@ -34,9 +34,11 @@
 
 SUB_FILES=	pkg-message
 
-OPTIONS_DEFINE=	ID3TAG IPV6 AVAHI FLAC VORBIS WAV FFMPEG TREMOR AAC \
+OPTIONS_DEFINE=	ID3TAG IPV6 FLAC VORBIS WAV FFMPEG TREMOR AAC \
 		MUSEPACK MIKMOD MODPLUG ARCHIVE MMS LASTFM AO PULSEAUDIO \
 		JACK SHOUTCAST SNDFILE LAME HTTPD SAMPLERATE CUE
+OPTIONS_RADIO=	ZEROCONF
+OPTIONS_RADIO_ZEROCONF=	AVAHI MDNSRESPONDER
 
 OPTIONS_DEFAULT=ID3TAG IPV6 FLAC VORBIS WAV FFMPEG SNDFILE 
 LAME_DESC=	Support for MP3 Icecast Streams
@@ -179,6 +181,13 @@
 CONFIGURE_ARGS+=--with-zeroconf=no
 .endif
 
+.if ${PORT_OPTIONS:MMDNSRESPONDER}
+CONFIGURE_ARGS+=--with-zeroconf=bonjour
+LIB_DEPENDS+=	dns_sd:${PORTSDIR}/net/mDNSResponder
+.else
+CONFIGURE_ARGS+=--with-zeroconf=no
+.endif
+
 .if ${PORT_OPTIONS:MAO}
 CONFIGURE_ARGS+=--enable-ao
 LIB_DEPENDS+=	ao.4:${PORTSDIR}/audio/libao


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ports-bugs mailing list