ports/177428: [PATCH] editors/emacs: missing INSTALLS_ICONS

[Bryan Drewery]

>Number:         177428
>Category:       ports
>Synopsis:       [PATCH] editors/emacs: missing INSTALLS_ICONS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 28 02:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Bryan Drewery
>Release:        FreeBSD 8.3-RELEASE-p5 i386
>Organization:
>Environment:

	
>Description:
	emacs, emacs-devel and emacs23 each install icons into share/icons/hicolor, but do not use INSTALLS_ICONS. This results in the cache not being built (so they are not usable), and creates a situation where the cache file is missing until another port is installed, so when that port is tested, the cache is seen as a leftover. See ports/170490 for example
>How-To-Repeat:
	
>Fix:

	Patch mirrored at http://people.freebsd.org/~bdrewery/emacs-icon-leftovers.txt
	Passing buildlogs at http://poudriere.shatow.net/bulk/83i386-dev-test/2013-03-27_20:11:30/logs/

--- emacs-icon-leftovers.txt begins here ---
# svn status
M       editors/emacs/Makefile
M       editors/emacs-devel/Makefile
M       editors/emacs23/Makefile

Index: editors/emacs/Makefile
===================================================================
--- editors/emacs/Makefile	(revision 315416)
+++ editors/emacs/Makefile	(working copy)
@@ -30,6 +30,7 @@
 USE_GMAKE=	yes
 USE_NCURSES=	yes
 USE_XZ=		yes
+INSTALLS_ICONS=	yes
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 CONFIGURE_ARGS=	--localstatedir=/var
Index: editors/emacs-devel/Makefile
===================================================================
--- editors/emacs-devel/Makefile	(revision 315416)
+++ editors/emacs-devel/Makefile	(working copy)
@@ -32,6 +32,7 @@
 USE_GMAKE=	yes
 USE_NCURSES=	yes
 USE_XZ=		yes
+INSTALLS_ICONS=	yes
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 CONFIGURE_ARGS=	--localstatedir=/var
Index: editors/emacs23/Makefile
===================================================================
--- editors/emacs23/Makefile	(revision 315416)
+++ editors/emacs23/Makefile	(working copy)
@@ -31,6 +31,7 @@
 USE_GMAKE=	yes
 USE_BZIP2=	yes
 USE_NCURSES=	yes
+INSTALLS_ICONS=	yes
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 CONFIGURE_ARGS=	--localstatedir=/var
--- emacs-icon-leftovers.txt ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: