ports/176851: [patch] net-im/pidgin segmentation fault with cap plugin

[Ivan Klymenko]

>Number:         176851
>Category:       ports
>Synopsis:       [patch] net-im/pidgin segmentation fault with cap plugin
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 11 14:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Ivan Klymenko
>Release:        FreeBSD 10.0-CURRENT
>Organization:
individual
>Environment:
FreeBSD nonamehost 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sat Mar  9 23:29:58 EET 2013     root at nonamehost:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
when compiling the port encounter the following warnings:
..
cap.c: In function 'generate_prediction_for':
cap.c:46: warning: initialization makes integer from pointer without a cast
cap.c:97: warning: assignment makes integer from pointer without a cast
cap.c:99: warning: passing argument 1 of 'strcmp' makes pointer from integer without a cast
..

and occurs segmentation fault:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 80a806400 (LWP 101046/pidgin)]
0x000000080cb03ef1 in get_stats_for (buddy=<value optimized out>) at cap.c:99
99		if(sta_id && !strcmp(sta_id, "offline")) {

>How-To-Repeat:
run pidgin
>Fix:
fixing in patch

Patch attached with submission follows:

--- pOidgin/plugins/cap/cap.c.orig	2013-03-11 15:40:09.000000000 +0200
+++ pOidgin/plugins/cap/cap.c	2013-03-11 15:40:17.000000000 +0200
@@ -43,7 +43,7 @@
 	int threshold = purple_prefs_get_int("/plugins/gtk/cap/threshold");
 	int min_minute = (current_minute - threshold) % 1440;
 	int max_minute = (current_minute + threshold) % 1440;
-	char *sql, sta_id = NULL;
+	char *sql, *sta_id = NULL;
 	sqlite3_stmt *stmt = NULL;
 	const char *tail = NULL;
 	int rc;


>Release-Note:
>Audit-Trail:
>Unformatted: