ports/176795: [PATCH] java/jakarta-commons-httpclient 3.1_1 fails to build

[Eric Krausser]

>Number:         176795
>Category:       ports
>Synopsis:       [PATCH] java/jakarta-commons-httpclient 3.1_1 fails to build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 09 22:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Eric Krausser
>Release:        9.1-RELEASE amd64
>Organization:
private
>Environment:
FreeBSD builder-workstation.local 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root at farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
jakarta-commons-httpclient fails to build because of non-UTF8 symbol,
see PR ports/165774


error message:
compile:
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/build.xml:184: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
    [javac] Compiling 139 source files to /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/target/classes
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/HttpContentTooLargeException.java:6: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl?ck
    [javac]                     ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/WireLogInputStream.java:40: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                     ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/WireLogInputStream.java:40: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                      ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/WireLogInputStream.java:40: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                       ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/auth/HttpAuthenticator.java:65: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                     ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/auth/HttpAuthenticator.java:65: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                      ^
    [javac] /usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/src/java/org/apache/commons/httpclient/auth/HttpAuthenticator.java:65: error: unmappable character for encoding ASCII
    [javac]  * @author Ortwin Gl???ck
    [javac]                       ^
    [javac] 7 errors

BUILD FAILED
/usr/ports/java/jakarta-commons-httpclient/work/commons-httpclient-3.1/build.xml:184: Compile failed; see the compiler error output for details.

>How-To-Repeat:
try to build the port in a clean jail
>Fix:
please apply the attached patch, it does reverse the change from revision 312555 to 312556

Patch attached with submission follows:

diff -ruN --exclude=CVS /usr/ports/java/jakarta-commons-httpclient/Makefile ./Makefile
--- /usr/ports/java/jakarta-commons-httpclient/Makefile	2013-03-09 23:00:35.291758378 +0100
+++ ./Makefile	2013-03-09 23:00:20.543757738 +0100
@@ -32,6 +32,11 @@
 
 PORTDOCS=	*
 
+post-patch:
+		@LANG=C ${REINPLACE_CMD} 's/Ortwin Gl.*ck/Ortwin Glueck/' \
+			${WRKSRC}/src/java/org/apache/commons/httpclient/*.java \
+			${WRKSRC}/src/java/org/apache/commons/httpclient/*/*.java
+
 do-install:
 	@${ECHO_MSG} -n ">> Installing JAR file as ${JAVAJARDIR}/${PORTNAME}.jar..."
 	@${INSTALL_DATA} ${WRKSRC}/dist/${PORTNAME}.jar ${JAVAJARDIR}/


>Release-Note:
>Audit-Trail:
>Unformatted: