ports/175482: mail/claws-mail shouldn't enable the crash dialog if the DEBUG option is used

[Fabian Keil]

>Number:         175482
>Category:       ports
>Synopsis:       mail/claws-mail shouldn't enable the crash dialog if the DEBUG option is used
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 21 17:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Fabian Keil
>Release:        HEAD
>Organization:
>Environment:
FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #540 r+2048695: Thu Jan 17 14:09:36 CET 2013     fk at r500.local:/usr/obj/usr/src/sys/ZOEY  amd64

>Description:
In my experience claws-mail's crash dialog causes more problems than it solves.

The stack trace is usually bogus, can't be generated or claws-mail simply becomes unresponsive instead of properly creating a core dump that would actually be useful.

In case of claws-mail 3.9.0 "killall -SIGSEGV claws-mail" merely causes the
following console messages to appear:

claws.c:102:Starting Claws Mail version Claws Mail 3.9.0
main.c:2378:another Claws Mail instance is already running.

No dialog is shown and the GUI becomes unresponsive.

If http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2862
wasn't reproducible, I wouldn't have been able to figure out the problem (which happened in the past).

Even if the crash dialog would work, I'd prefer it to be a separate option instead of being set depending on the DEBUG option. My expectation when compiling ports with DEBUG is getting usable core dumps.
>How-To-Repeat:
1. Build the claws-mail port with "DEBUG" support
2. Crash claws-mail
3. Notice that there is no core dump to analyze
>Fix:
The attached patch removes the --enable-crash-dialog configure option which solves the problem for me.

Patch attached with submission follows:

>From 522f825a954e79562580b5f4fd8008fb970cc1e7 Mon Sep 17 00:00:00 2001
From: Fabian Keil <fk at fabiankeil.de>
Date: Mon, 21 Jan 2013 17:23:42 +0100
Subject: [PATCH] Don't enable the claws-mail 'crash dialog' which usually makes debugging
 harder

---
 mail/claws-mail/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mail/claws-mail/Makefile b/mail/claws-mail/Makefile
index 79b5266..c41e019 100644
--- a/mail/claws-mail/Makefile
+++ b/mail/claws-mail/Makefile
@@ -151,7 +151,7 @@ CONFIGURE_ARGS+=	--disable-pgpmime-plugin --disable-pgpcore-plugin \
 .endif
 
 .if ${PORT_OPTIONS:MDEBUG}
-CONFIGURE_ARGS+=	--enable-maintainer-mode --enable-crash-dialog
+CONFIGURE_ARGS+=	--enable-maintainer-mode
 .endif
 
 .if ${PORT_OPTIONS:MDILLO}
-- 
1.8.1



>Release-Note:
>Audit-Trail:
>Unformatted: