ports/175054: [PATCH] multimedia/audacious-plugins 3.3.3 fails building package with option SMB

[Eric Krausser]

>Number:         175054
>Category:       ports
>Synopsis:       [PATCH] multimedia/audacious-plugins 3.3.3 fails building package with option SMB
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 06 01:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Eric Krausser
>Release:        9.1-RELEASE amd64
>Organization:
private
>Environment:
FreeBSD schleppi.local 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root at farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
The port fails to create a package if option SMB is set, because the audacious-plugin "Transport smb" was removed 7 months ago from the sources but this plugin binary is in the pkg-plist. (SMB protocol is supported by the plugin "GIO".)

See https://github.com/audacious-media-player/audacious-plugins/commit/2477bd6dc652af907d15acf1abdf4ca2d0030eb5

>How-To-Repeat:
/usr/ports/multimedia/audacious-plugins # make showconfig
===> The following configuration options are available for audacious-plugins-3.3.3:
..
     SMB=on: SMB protocol
..
===> Use 'make config' to modify these settings



/usr/ports/multimedia/audacious-plugins # make deinstall clean package
..
===>   Registering installation for audacious-plugins-3.3.3
===>  Building package for audacious-plugins-3.3.3
tar: lib/audacious/Transport/smb.so: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors.
pkg_create: make_dist: tar command failed with code 256
*** [do-package] Error code 1
Stop in /usr/ports/multimedia/audacious-plugins.



/usr/ports/multimedia/audacious-plugins # make deinstall
===>  Deinstalling for multimedia/audacious-plugins
===>   Deinstalling audacious-plugins-3.3.3
pkg_delete: file '/usr/local/lib/audacious/Transport/smb.so' doesn't exist
pkg_delete: unable to completely remove directory '/usr/local/lib/audacious/Effect'
pkg_delete: unable to completely remove directory '/usr/local/share/doc/audacious-plugins'
pkg_delete: couldn't entirely delete package `audacious-plugins-3.3.3'
(perhaps the packing list is incorrectly specified?)

>Fix:
Please use the attached patch, it does:

Makefile
- fix the portlint warnings about header and PORT_OPTIONS:MDOCS
- remove option SMB

pkg-plist
- remove entry lib/audacious/Transport/smb.so
- fix the pkg_delete warnings


Patch attached with submission follows:

diff -ruN --exclude=CVS /usr/ports/multimedia/audacious-plugins/Makefile ./Makefile
--- /usr/ports/multimedia/audacious-plugins/Makefile    2013-01-06 01:18:03.460874402 +0100
+++ ./Makefile  2013-01-06 01:46:56.477914725 +0100
@@ -1,9 +1,4 @@
-# New ports collection makefile for:   audacious
-# Date created:                        2006-01-01
-# Whom:                                Zastupov Stepan [RedChrom] <redchrom at mail.ru>
-#
-# $FreeBSD: ports/multimedia/audacious-plugins/Makefile,v 1.103 2012/12/19 20:17:40 svnexp Exp $
-#
+# $FreeBSD$
 
 PORTNAME=      audacious-plugins
 PORTVERSION=   3.3.3
@@ -30,7 +25,7 @@
 
 OPTIONS_DEFINE=        DBUS OSS4 SDLOUT ALSA CUE MP3 STATUSICON AOSD AOSDXCOMP \
                                ADPLUG VORBIS FLAC WAVPACK AAC SNDFILE MODPLUG JACK SID \
-                               CDAUDIO SCROBBLER MMS  GIO SMB MTP NLS RESAMPLE AMIDI \
+                               CDAUDIO SCROBBLER MMS GIO MTP NLS RESAMPLE AMIDI \
                                NOTIFY BS2B FFAUDIO PULSE NEON
 OPTIONS_DEFAULT=       DBUS CUE MP3 STATUSICON AOSD AOSDXCOMP AAC CDAUDIO \
                                        SCROBBLER NEON NLS OSS4
@@ -326,16 +321,6 @@
 PLIST_SUB+=    GIOPLUGIN="@comment "
 .endif
 
-.if ${PORT_OPTIONS:MSMB}
-SAMBA_PORT?=   net/samba34
-LIB_DEPENDS+=  smbclient:${PORTSDIR}/net/samba-libsmbclient
-CONFIGURE_ARGS+=--enable-smb
-PLIST_SUB+=    SMBPLUGIN=""
-.else
-CONFIGURE_ARGS+=--disable-smb
-PLIST_SUB+=    SMBPLUGIN="@comment "
-.endif
-
 .if ${PORT_OPTIONS:MNLS}
 USE_GETTEXT=   yes
 CONFIGURE_ARGS+=--enable-nls
@@ -378,7 +363,7 @@
        @${ECHO_MSG} "ALL PRESETS will be stored in the gconf database."
        @${ECHO_MSG} ""
 .endif
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
        @${MKDIR} ${DOCSDIR}
 .for i in ${PORTDOCS}
        ${INSTALL_DATA} ${WRKSRC}/${i} ${DOCSDIR}
diff -ruN --exclude=CVS /usr/ports/multimedia/audacious-plugins/pkg-plist ./pkg-plist
--- /usr/ports/multimedia/audacious-plugins/pkg-plist   2013-01-06 01:18:27.024048052 +0100
+++ ./pkg-plist 2013-01-06 01:18:13.000000000 +0100
@@ -152,7 +152,6 @@
 %%MMSPLUGIN%%lib/audacious/Transport/mms.so
 %%NEONPLUGIN%%lib/audacious/Transport/neon.so
 lib/audacious/Transport/unix-io.so
-%%SMBPLUGIN%%lib/audacious/Transport/smb.so
 %%GIOPLUGIN%%lib/audacious/Transport/gio.so
 %%AMIDIPLUGIN%%lib/audacious/Input/amidi-plug.so
 %%AMIDIAPLUGIN%%lib/audacious/Input/amidi-plug/ap-alsa.so
@@ -181,6 +180,7 @@
 lib/audacious/Effect/ladspa.so
 lib/audacious/Effect/mixer.so
 lib/audacious/Effect/echo.so
+lib/audacious/Effect/speed-pitch.so
 lib/audacious/Effect/voice_removal.so
 %%BS2BPLUGIN%%lib/audacious/Effect/bs2b.so
 lib/audacious/Visualization/blur_scope.so
@@ -237,5 +237,4 @@
 %%NLS%%@dirrmtry share/locale/sr_RS
 %%NLS%%@dirrmtry share/locale/es_AR/LC_MESSAGES
 %%NLS%%@dirrmtry share/locale/es_AR
- at dirrm %%DOCSDIR%%
 @dirrmtry share/audacious


>Release-Note:
>Audit-Trail:
>Unformatted: