ports/175034: biology/povchem: Fix build with clang

[KATO Tsuguru]

>Number:         175034
>Category:       ports
>Synopsis:       biology/povchem: Fix build with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 05 18:10:09 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     KATO Tsuguru
>Release:        FreeBSD 7.4-RELEASE-p10 i386
>Organization:
>Environment:
>Description:
- Fix build with clang
- Support PLIST_FILES

Remove file:
pkg-plist

>How-To-Repeat:
>Fix:

diff -urN /usr/ports/biology/povchem/Makefile biology/povchem/Makefile
--- /usr/ports/biology/povchem/Makefile	2012-11-08 06:52:52.000000000 +0900
+++ biology/povchem/Makefile	2012-12-03 23:36:26.000000000 +0900
@@ -1,9 +1,5 @@
-# New ports collection Makefile for: povchem
-# Date created:         Mar 14 1998
-# Whom:                 frankch at waru.life.nthu.edu.tw
-#
+# Created by: frankch at waru.life.nthu.edu.tw
 # $FreeBSD: head/biology/povchem/Makefile 300895 2012-07-14 12:56:14Z beat $
-#
 
 PORTNAME=	povchem
 PORTVERSION=	1.0
@@ -13,6 +9,8 @@
 DISTFILES=	povchem.c \
 		povchem.cfg \
 		periodic.tab
+DIST_SUBDIR=	povchem
+EXTRACT_ONLY=	#
 
 MAINTAINER=	ports at FreeBSD.org
 COMMENT=	Simple yet powerful tool to generate POV from a PDB file
@@ -20,31 +18,29 @@
 RUN_DEPENDS=	povray:${PORTSDIR}/graphics/povray-meta
 
 NO_WRKSUBDIR=	yes
-DIST_SUBDIR=	povchem
 
-DEFS=		-DDATADIR=\"${PREFIX}/share/povchem\" \
+USE_DOS2UNIX=	povchem.c
+
+CPPFLAGS+=	-DDATADIR=\"${DATADIR}\" \
 		-DSYSCONFDIR=\"${PREFIX}/etc\"
-PATCH_ARGS=	-l -d ${PATCH_WRKSRC} --forward --quiet -E ${PATCH_STRIP}
 
-do-extract:
-	@${MKDIR} ${WRKSRC}
-.for file in ${DISTFILES}
-	@${CP} ${_DISTDIR}/${file} ${WRKSRC}
-.endfor
+PLIST_FILES=	bin/povchem etc/povchem.cfg %%DATADIR%%/periodic.tab
+
+post-extract:
+	@(cd ${DISTDIR}/${DIST_SUBDIR} && ${TAR} -cf - ${DISTFILES}) | \
+		(cd ${WRKSRC} && ${TAR} -xf -)
 
 post-patch:
-	@${REINPLACE_CMD} -e "s|%%LOCALBASE%%|${LOCALBASE}|g" \
-	${WRKSRC}/povchem.cfg
-	${MV} ${WRKSRC}/povchem.c ${WRKSRC}/povchem.c.patched
-	strings -1 ${WRKSRC}/povchem.c.patched > ${WRKSRC}/povchem.c
+	@${REINPLACE_CMD} -e \
+		's|%%LOCALBASE%%|${LOCALBASE}|' ${WRKSRC}/povchem.cfg
 
 do-build:
-	cd ${WRKSRC} && ${CC} ${CFLAGS} ${DEFS} -o povchem povchem.c -lm
+	cd ${WRKSRC} && ${CC} ${CFLAGS} ${CPPFLAGS} -o povchem povchem.c -lm
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/povchem ${PREFIX}/bin
 	${INSTALL_DATA} ${WRKSRC}/povchem.cfg ${PREFIX}/etc
-	@${MKDIR} ${PREFIX}/share/povchem
-	${INSTALL_DATA} ${WRKSRC}/periodic.tab ${PREFIX}/share/povchem
+	@${MKDIR} ${DATADIR}
+	${INSTALL_DATA} ${WRKSRC}/periodic.tab ${DATADIR}
 
 .include <bsd.port.mk>
diff -urN /usr/ports/biology/povchem/files/patch-ab biology/povchem/files/patch-ab
--- /usr/ports/biology/povchem/files/patch-ab	2012-11-08 06:52:52.000000000 +0900
+++ biology/povchem/files/patch-ab	2013-01-02 02:28:22.000000000 +0900
@@ -177,3 +177,12 @@
                eye.x,eye.y,eye.z);
  
    fputs(      "camera{\n",pov);
+@@ -2317,7 +2317,7 @@
+ 
+ /*-------------------- the main program body --------------------------*/
+ 
+-void main(int argc, char *argv[])
++int main(int argc, char *argv[])
+ {
+   char *pdbName, *configName=NULL;
+   char *tgaName=NULL, *leftTga=NULL, *rightTga=NULL;
diff -urN /usr/ports/biology/povchem/pkg-plist biology/povchem/pkg-plist
--- /usr/ports/biology/povchem/pkg-plist	2012-11-08 06:52:52.000000000 +0900
+++ biology/povchem/pkg-plist	1970-01-01 09:00:00.000000000 +0900
@@ -1,4 +0,0 @@
-bin/povchem
-etc/povchem.cfg
-share/povchem/periodic.tab
- at dirrm share/povchem
>Release-Note:
>Audit-Trail:
>Unformatted: