ports/174913: [patch] update games/gemrb 0.7.1 to 0.7.2
Timothy Beyer
beyert at cs.ucr.edu
Thu Jan 3 08:00:02 UTC 2013
The following reply was made to PR ports/174913; it has been noted by GNATS.
From: Timothy Beyer <beyert at cs.ucr.edu>
To: bug-followup at FreeBSD.org, Jakub Lach <jakub_lach at mailplus.pl>
Cc: beyert at cs.ucr.edu
Subject: Re: ports/174913: [patch] update games/gemrb 0.7.1 to 0.7.2
Date: Wed, 02 Jan 2013 23:59:27 -0800
At Wed, 2 Jan 2013 22:00:28 UT,
Edwin Groothuis wrote:
>
> Maintainer of games/gemrb,
>
> Please note that PR ports/174913 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174913
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin at FreeBSD.org
>
Hi,
Jackub, can you follow up with your improved patch? I tested it with portlint -CA, and the main thing that it doesn't like is the lack of INSTALLS_ICONS. I agree with you, (so much unnecessary GNOME bloat on many ports) however, I have no idea of another way to do it... I'm OK with omitting that, but it depends what the opinions of committers are on this matter, as I'd rather not defy portlint without justification.
I tested the improved patch that you sent me which builds, installs, uninstalls and runs properly.
As for the pkg-plist, yes that is the way I generate it, and it looks fine (your revised patch is better though, please follow up to this message with that patch)
Approved, depending on what the call is on INSTALLS_ICONS.
Regards,
Tim
More information about the freebsd-ports-bugs
mailing list