ports/176257: Makefile problem in knock port

[Jed Clear]

>Number:         176257
>Category:       ports
>Synopsis:       Makefile problem in knock port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 19 01:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Jed Clear
>Release:        8.3-R
>Organization:
n/a
>Environment:
FreeBSD fbsdvm1.my.domain 8.3-RELEASE-p5 FreeBSD 8.3-RELEASE-p5 #0 r244809: Sat Dec 29 07:50:22 EST 2012     root at fbsdvm1.my.domain:/usr/obj/usr/src/sys/VM1  amd64

>Description:
Freshly svn updated ports tree.  Tried to build knock port (/usr/ports/security/knock)

build32# make
===>  knock-0.5_1,1 at least one component must be selected for installation.
*** Error code 1

Stop in /usr/ports/security/knock.
build32# 

Looked at Makefile, the pre-configure target seems to have incorrect logic.  Not sure of make logical syntax, but seems like you need:
      not MSERVER and not MCLIENT 
in the if statement around the IGNORE.

If I do a make config and deselect one option, the build succeeds.
>How-To-Repeat:

cd /usr/ports/security/knock 
make config (and select both options if not still at the default setting)
make
>Fix:
Change logic in the Makefile pre-config target such that the if is only true if both are UNdefined.

>Release-Note:
>Audit-Trail:
>Unformatted: