ports/176131: multimedia/libva has incomplete dependencies causing libva-glx.so to not be configured to build under poudriere

[Christopher Dukes]

>Number:         176131
>Category:       ports
>Synopsis:       multimedia/libva has incomplete dependencies causing libva-glx.so to not be configured to build under poudriere
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 13 23:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Christopher Dukes
>Release:        9.1
>Organization:
Squirrely Girl Produce
>Environment:
FreeBSD basement-00 9.1-RELEASE FreeBSD 9.1-RELEASE #1: Tue Jan  1 07:25:00 EST 2013     root at basement-00:/usr/obj/usr/src/sys/VIMAGE  amd64

>Description:
Found this while trying to track down a config bug in multimedia/xbmc under poudriere.
I expect most people building this already have the x11/xorg-libraries, graphics/libGL, and x11/glproto installed prior to attempting to build this package.  Unfortunately, that isn't the case if using a clean build environment like poudriere.
>How-To-Repeat:
Build under poudriere with pkgng enabled in the poudriere environment.

Note the following section of the build.

===>   Registering installation for libva-1.1.0_2
pkg: lstat(/usr/local/include/va/va_backend_glx.h): No such file or directory
pkg: lstat(/usr/local/include/va/va_glx.h): No such file or directory
pkg: lstat(/usr/local/lib/libva-glx.la): No such file or directory
pkg: lstat(/usr/local/lib/libva-glx.so): No such file or directory
pkg: lstat(/usr/local/lib/libva-glx.so.1): No such file or directory
pkg: lstat(/usr/local/libdata/pkgconfig/libva-glx.pc): No such file or directory


>Fix:
Add the appropriate dependencies to the BUILD_DEPENDS and LIB_DEPENDS, may need to actually be in RUN_DEPENDS or revised properly for LIB_DEPENDS.

The attached patch seems to address the issue, but probably needs to be finessed slightly.

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 312162)
+++ Makefile	(working copy)
@@ -12,9 +12,12 @@
 LICENSE=	MIT
 LICENSE_FILE=	${WRKSRC}/COPYING
 
-BUILD_DEPENDS=	${LOCALBASE}/include/linux/videodev2.h:${PORTSDIR}/multimedia/v4l_compat
-LIB_DEPENDS=	drm:${PORTSDIR}/graphics/libdrm
+BUILD_DEPENDS=	${LOCALBASE}/include/linux/videodev2.h:${PORTSDIR}/multimedia/v4l_compat 
+BUILD_DEPENDS+= /usr/local/libdata/xorg/libraries:${PORTSDIR}/x11/xorg-libraries
+BUILD_DEPENDS+=  /usr/local/libdata/pkgconfig/glproto.pc:${PORTSDIR}/x11/glproto
 
+LIB_DEPENDS=	drm:${PORTSDIR}/graphics/libdrm GL:${PORTSDIR}/graphics/libGL 
+
 USE_BZIP2=	yes
 USE_XORG=	pciaccess xext xfixes
 USE_GL=		gl


>Release-Note:
>Audit-Trail:
>Unformatted: