ports/185301: news/inn: INN_LAYOUT ignored on 10.0+

[Christian Weisgerber]

>Number:         185301
>Category:       ports
>Synopsis:       news/inn: INN_LAYOUT ignored on 10.0+
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 30 16:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Christian Weisgerber
>Release:        FreeBSD 10.0-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD lorvorc.mips.inka.de 10.0-PRERELEASE FreeBSD 10.0-PRERELEASE #0 r260003:260005: Sat Dec 28 18:12:24 CET 2013 naddy at lorvorc.mips.inka.de:/usr/obj/usr/src/sys/GENERIC amd64

>Description:

On FreeBSD 10 and later, the news/inn port ignores the setting of
the INN_LAYOUT variable.

The problem is the use of the :L modifier in Makefile.layout.
FreeBSD 10 uses bmake and the meaning of :L has changed.  bsd.port.mk
works around this with the magic setting .MAKE.FreeBSD_UL=yes, but
Makefile.layout is included before this is in place.

>How-To-Repeat:

$ cd /usr/ports/news/inn
$ env INN_LAYOUT=hier make -V INN_DBDIR
/usr/local/news/db

>Fix:

Maybe including Makefile.layout later (which may be possible due
to make's lazy evaluation), or setting .MAKE.FreeBSD_UL in the port.

Index: Makefile.layout
===================================================================
--- Makefile.layout	(revision 337893)
+++ Makefile.layout	(working copy)
@@ -1,5 +1,8 @@
 # $FreeBSD$
 
+# tell bmake we use the old :L :U modifiers
+.MAKE.FreeBSD_UL= yes
+
 INN_LAYOUT?=		old
 
 .if !empty(INN_LAYOUT:L:Mnew)
>Release-Note:
>Audit-Trail:
>Unformatted: