ports/185042: graphics/libecwj2 : fails to build with recent compilers

[Christoph Moench-Tegeder]

>Number:         185042
>Category:       ports
>Synopsis:       graphics/libecwj2 : fails to build with recent compilers
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 20 18:50:02 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Christoph Moench-Tegeder
>Release:        FreeBSD 10.0-RC2 amd64
>Organization:
>Environment:
System: FreeBSD squirrel.exwg.net 10.0-RC2 FreeBSD 10.0-RC2 #0 r259645: Fri Dec 20 15:19:27 CET 2013 cmt at squirrel.exwg.net:/usr/obj/usr/src/sys/T520 amd64

graphics/libecwj2    libecwj2-3.3_1
cmt at squirrel:~$ cc --version
FreeBSD clang version 3.3 (tags/RELEASE_33/final 183502) 20130610
Target: x86_64-unknown-freebsd10.0
Thread model: posix

also verified on 9.2-RELEASE with gcc 4.7:
FreeBSD build.exwg.net 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013     root at bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

lang/gcc47    gcc47-4.7.4.20131214

>Description:
type make... the build fails with (gcc47 error message, clang fails with
the same reason):
../C/NCSnet/NCScnet3/NCSProxy.cpp: In member function 'char* CNCSProxy::GetCurrentUserName()':
../C/NCSnet/NCScnet3/NCSProxy.cpp:644:28: error: 'getlogin' was not declared in this scope

>How-To-Repeat:

>Fix:
NCSProxy.cpp needs to include unistd.h. Drop the following as
graphics/libecwj2/files/patch-Source-C-NCSnet-NCScnet3-NCSProxy.h :

--- Source/C/NCSnet/NCScnet3/NCSProxy.h.orig	2013-12-20 19:22:52.000000000 +0100
+++ Source/C/NCSnet/NCScnet3/NCSProxy.h	2013-12-20 19:23:26.000000000 +0100
@@ -35,6 +35,7 @@
 //#include <streambuf>
 #include <iostream>
 #include <sstream>
+#include <unistd.h>
 #include <ctype.h>
 #include <assert.h>
 #include <string>


Regards,
Christoph
>Release-Note:
>Audit-Trail:
>Unformatted: