ports/184571: math/abacus : fix build with gcc47

Christoph Moench-Tegeder cmt at burggraben.net
Sat Dec 7 17:00:03 UTC 2013


>Number:         184571
>Category:       ports
>Synopsis:       math/abacus : fix build with gcc47
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 07 17:00:02 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Christoph Moench-Tegeder
>Release:        FreeBSD 9.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD elch.exwg.net 9.2-RELEASE FreeBSD 9.2-RELEASE #11 r255911: Fri Sep 27 17:09:40 CEST 2013 cmt at elch.exwg.net:/usr/obj/usr/src/sys/ELCH amd64

lang/gcc47		gcc47-4.7.4.20131130
math/abacus		abacus-3.2.b1_1

>Description:
Hi,

in an effort towards upgrading lang/gcc to gcc 4.7, I'm helping gerald@
in making ports gcc47-safe.
Please consider the following patch to your port. If you approve of the
patch, gerald@ has offered his help in commiting it.
If you're commiting yourself or have someone else commit this (or
another patch to the same effect), can you please add an additional
reference to ports/183342 in the commit message?
In my test environment, the port built successfully with lang/gcc47.

>How-To-Repeat:

>Fix:

GCC 4.7 needs an explicit this-> on calls to member functions.

# fix calls to member functions
$ svn status
A       files/patch-Include-standardpool.inc

Index: files/patch-Include-standardpool.inc
===================================================================
--- files/patch-Include-standardpool.inc	(revision 0)
+++ files/patch-Include-standardpool.inc	(working copy)
@@ -0,0 +1,20 @@
+--- Include/abacus/standardpool.inc.orig	2013-11-16 14:06:39.000000000 +0100
++++ Include/abacus/standardpool.inc	2013-11-16 14:08:30.000000000 +0100
+@@ -129,7 +129,7 @@
+ 
+     for(int i = 0; i < ABA_POOL<BaseType, CoType>::number(); i++) 
+       {
+-      if(softDeleteConVar(pool_[i]) == 0)
++      if(this->softDeleteConVar(pool_[i]) == 0)
+         {
+          nDeleted++;
+ 	 // consider the case that a slot has been deleted although it was empty
+@@ -179,7 +179,7 @@
+     
+     while(nRemoved < maxRemove && !candidates.empty()) {
+       c = candidates.extractMin();  
+-      hardDeleteConVar(pool_[c]);
++      this->hardDeleteConVar(pool_[c]);
+       nRemoved++;
+     }
+ 


Regards,
Christoph
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ports-bugs mailing list