ports/184552: net/netatalk3 now silently depends on libsunacl

[Bradley T. Hughes]

>Number:         184552
>Category:       ports
>Synopsis:       net/netatalk3 now silently depends on libsunacl
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 06 23:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Bradley T. Hughes
>Release:        10.0-BETA4
>Organization:
>Environment:
FreeBSD freebsd10.local 10.0-BETA4 FreeBSD 10.0-BETA4 #0 r258774: Sun Dec  1 00:51:31 UTC 2013     root at snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
After net/netatalk3 was updated to 3.1.0, the configure script picks up libsunacl if it was previously installed, but the port itself isn't marked as being dependent on libsunacl.
>How-To-Repeat:
1. make -C /usr/ports/sysutils/libsunacl install
2. make -C /usr/ports/net/netatalk3 install
3. pkg delete libsunacl
4. service netatalk start

The service fails to start because it can't find the libsunacl shared libraries (which were just removed).
>Fix:
See attached patch.

Patch attached with submission follows:

diff -urN /usr/ports/net/netatalk3/Makefile netatalk3/Makefile
--- /usr/ports/net/netatalk3/Makefile	2013-11-16 19:29:47.000000000 +0100
+++ netatalk3/Makefile	2013-12-03 07:04:19.534549353 +0100
@@ -3,6 +3,7 @@
 
 PORTNAME=	netatalk
 PORTVERSION=	3.1.0
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	net
 MASTER_SITES=	SF
@@ -36,7 +37,7 @@
 			--with-libevent-header=${LOCALBASE}/include \
 			--with-libevent-lib=${LOCALBASE}/lib/event2
 
-OPTIONS_DEFINE=PAM KRB5 LDAP SENDFILE KERBEROS DTRACE DBUS MYSQL
+OPTIONS_DEFINE=PAM KRB5 LDAP SENDFILE KERBEROS DTRACE DBUS MYSQL ACL
 OPTIONS_DEFAULT=KERBEROS DBUS
 OPTIONS_RADIO=ZEROCONF
 OPTIONS_RADIO_ZEROCONF=AVAHI MDNSRESPONDER
@@ -47,6 +48,7 @@
 DTRACE_DESC=	Enable DTrace support
 SENDFILE_DESC=	Enable Sendfile support
 MYSQL_DESC=	Enable MySQL CNID backend support
+ACL_DESC=	Enable ACL support
 
 .include <bsd.port.options.mk>
 
@@ -126,6 +128,13 @@
 CONFIGURE_ARGS+=--with-mysql-config=/nonexistent
 .endif
 
+.if ${PORT_OPTIONS:MACL}
+LIB_DEPENDS+=		sunacl:${PORTSDIR}/sysutils/libsunacl
+CONFIGURE_ARGS+=	--with-acls
+.else
+CONFIGURE_ARGS+=	--without-acls
+.endif
+
 .if ${OSVERSION} < 800031
 PLIST_SUB+=	ATFUNCS="@comment "
 .else


>Release-Note:
>Audit-Trail:
>Unformatted: