ports/181641: ssmtp provide option for CRAM-MD5 support

[Dewayne]

>Number:         181641
>Category:       ports
>Synopsis:       ssmtp provide option for CRAM-MD5 support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 29 08:20:02 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Dewayne
>Release:        FreeBSD 9.2
>Organization:
>Environment:
FreeBSD cb70.hs 9.2-PRERELEASE FreeBSD 9.2-PRERELEASE #0: Sun Aug 11 13:15:39 EST 2013
>Description:
cram-md5 is mandatory option for ssmtp.  The enclosed patch enables CRAM-MD5 as an option, it also enables XORIGIP as a default option which was the presumed intent.

Removing CRAM-MD5 removes an additional library that the dynamic loader needs to map, an extremely small performance enhancement and the removal of libmd when not required (for tight memory requirements).  The latter is beneficial in an environment with many jails and an email reporting/monitoring function.

(Unfortunately TLS is the only other secure authentication option)
>How-To-Repeat:

>Fix:
--- /usr/jails/b2/usr/ports/mail/ssmtp/Makefile (revision 324648)
+++ /usr/jails/b2/usr/ports/mail/ssmtp/Makefile (working copy)
@@ -22,7 +22,7 @@

 SUB_FILES+=    pkg-message
 PKGMESSAGE=    ${WRKDIR}/pkg-message
-CONFIGURE_ARGS=        --enable-ssl --enable-md5auth
+CONFIGURE_ARGS=        --enable-ssl
 MAKE_ENV+=     TARGET_ARCH=
 CFLAGS+=       -I${OPENSSLINC}
 LDFLAGS+=      -L${OPENSSLLIB}
@@ -31,7 +31,7 @@
 MAN8=          ssmtp.8
 MAN5=          ssmtp.conf.5

-OPTIONS_DEFINE=        LOGFILE IPV6 USERPREFS XORIGIP
+OPTIONS_DEFINE=        LOGFILE IPV6 USERPREFS XORIGIP CRAM-MD5
 OPTIONS_DEFINE= USERPREFS XORIGIP
 LOGFILE_DESC=  log file
 USERPREFS_DESC=        user defined revaliases
@@ -51,6 +51,10 @@
 CONFIGURE_ARGS+=       --enable-inet6
 .endif

+.if ${PORT_OPTIONS:MCRAM-MD5}
+CONFIGURE_ARGS+=        --enable-md5auth
+.endif
+
 .if ${PORT_OPTIONS:MUSERPREFS}
 CFLAGS+=       -DUSERPREFS
 pre-everything::
root@:~ # /root/static/svn diff /usr/jails/b2/usr/ports/mail/ssmtp/Makefile
Index: /usr/jails/b2/usr/ports/mail/ssmtp/Makefile
===================================================================
--- /usr/jails/b2/usr/ports/mail/ssmtp/Makefile (revision 324648)
+++ /usr/jails/b2/usr/ports/mail/ssmtp/Makefile (working copy)
@@ -22,7 +22,7 @@

 SUB_FILES+=    pkg-message
 PKGMESSAGE=    ${WRKDIR}/pkg-message
-CONFIGURE_ARGS=        --enable-ssl --enable-md5auth
+CONFIGURE_ARGS=        --enable-ssl
 MAKE_ENV+=     TARGET_ARCH=
 CFLAGS+=       -I${OPENSSLINC}
 LDFLAGS+=      -L${OPENSSLLIB}
@@ -31,12 +31,12 @@
 MAN8=          ssmtp.8
 MAN5=          ssmtp.conf.5

-OPTIONS_DEFINE=        LOGFILE IPV6 USERPREFS XORIGIP
-OPTIONS_DEFINE= USERPREFS XORIGIP
+OPTIONS_DEFINE=        LOGFILE IPV6 USERPREFS XORIGIP CRAM-MD5
+OPTIONS_DEFAULT= XORIGIP
 LOGFILE_DESC=  log file
 USERPREFS_DESC=        user defined revaliases
 XORIGIP_DESC=  Add X-Originating-IP header
-
+CRAM-MD5_DESC=  Enable CRAM-MD5 Authentication
 .include <bsd.port.options.mk>

 .if ${PORT_OPTIONS:MLOGFILE}
@@ -51,6 +51,10 @@
 CONFIGURE_ARGS+=       --enable-inet6
 .endif

+.if ${PORT_OPTIONS:MCRAM-MD5}
+CONFIGURE_ARGS+=        --enable-md5auth
+.endif
+
 .if ${PORT_OPTIONS:MUSERPREFS}
 CFLAGS+=       -DUSERPREFS
 pre-everything::


>Release-Note:
>Audit-Trail:
>Unformatted: