ports/172149: textproc/aspell ignores NLS option

[Gennady Proskurin]

>Number:         172149
>Category:       ports
>Synopsis:       textproc/aspell ignores NLS option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 28 18:30:08 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Gennady Proskurin
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD gpr.nnz-home.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r240189: Sat Sep  8 04:29:12 MSK 2012     gpr at gpr.nnz-home.ru:/usr/obj/usr/src/freebsd-head/sys/GPR  amd64
>Description:
textproc/aspell always depends on gettext, ignoring NLS option

Bug was introduced in revision 1.102
See also 1.86-1.87 patch

>How-To-Repeat:
Turn off NLS option, and then:
/usr/ports/textproc/aspell % make depends
===>   aspell-0.60.6.1_2 depends on file: /usr/local/bin/perl5.14.2 - found
===>   aspell-0.60.6.1_2 depends on file: /usr/local/bin/perl5.14.2 - found
===>   aspell-0.60.6.1_2 depends on shared library: iconv.3 - found
===>   aspell-0.60.6.1_2 depends on shared library: intl - found
===>   aspell-0.60.6.1_2 depends on executable: gmake - found
===>   aspell-0.60.6.1_2 depends on file: /usr/local/bin/perl5.14.2 - found

You see intl dependency

>Fix:
patch attached


Patch attached with submission follows:

--- textproc/aspell/Makefile	2012-09-28 19:35:02.384124434 +0400
+++ /tmp/aspell/Makefile	2012-09-28 20:55:27.000000000 +0400
@@ -35,15 +35,14 @@
 SUB_LIST=		VERINST=${VERINST}
 
 .include <bsd.port.options.mk>
 .if ${PORT_OPTIONS:MNLS}
 USE_GETTEXT=		yes
 PLIST_SUB+=		NLS=""
 .else
-USE_GETTEXT=	yes
 CONFIGURE_ARGS+=	--disable-nls
 PLIST_SUB+=		NLS="@comment "
 .endif
 
 .if ${PORT_OPTIONS:MISPELL}
 CONFLICTS+=            ispell* ??-ispell*
 SCRIPTS=               ispell spell


>Release-Note:
>Audit-Trail:
>Unformatted: