ports/171707: multimedia/mplayer: i386 clang build error

[anonymous]

>Number:         171707
>Category:       ports
>Synopsis:       multimedia/mplayer: i386 clang build error
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 17 12:40:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     anonymous
>Release:        FreeBSD 9.1-RC1 i368
>Organization:
>Environment:
FreeBSD FreeBSD 9.1-RC1 FreeBSD 9.1-RC1 #0: Thu Aug 23 10:16:04 PDT 2012     root at FreeBSD:/usr/obj/usr/src/sys/CUSTOM  i386
>Description:
Clang fails when building mp3lib on i386.

clang -MD -MP -D_ISOC99_SOURCE -D_BSD_SOURCE -O2 -pipe -O3
-fomit-frame-pointer -ffast-math -fno-strict-aliasing
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FILE_OFFSET_BITS=64
-Ilibdvdread4 -I. -Iffmpeg -I/usr/local/include -I/usr/local/include
-I/usr/local/include  -I/usr/local/include/freetype2
-I/usr/local/include -fomit-frame-pointer -c -o mp3lib/decode_i586.o
mp3lib/decode_i586.c
mp3lib/decode_i586.c:65:23: error: unknown token in expression
"        pushl %%eax\n\t"
                      ^
<inline asm>:22:18: note: instantiated into assembly here
                movl 4+(%esp),%edx
                        ^
mp3lib/decode_i586.c:68:23: error: unknown token in expression
"        pushl %%eax\n\t"
                      ^
<inline asm>:25:18: note: instantiated into assembly here
                movl 8+(%esp),%eax
                        ^
2 errors generated.
gmake: *** [mp3lib/decode_i586.o] Error 1
gmake: *** Waiting for unfinished jobs....
3 warnings generated.
*** Error code 1
>How-To-Repeat:

>Fix:
"As part of the code cleanup efforts, the internal libfaad2 copy has been removed since the FFmpeg decoder is working well. Also the internal mp3lib copy is no longer used by default since the many alternatives (FFmpeg, libmpg123, libmad) avoid its recurring issues like incorrect decoding with newer compilers. However it can still be forced at runtime for easier tracking of regressions. Please do not rely on this since it will be removed in the future. If you do not actually need it consider disabling it at compile time with --disable-mp3lib."
http://www.mplayerhq.hu/design7/news.html

Patch attached with submission follows:

diff -u mplayer.orig/Makefile mplayer/Makefile
--- mplayer.orig/Makefile	2012-09-17 05:31:58.240233837 -0700
+++ mplayer/Makefile	2012-09-17 05:30:23.915234903 -0700
@@ -92,7 +92,8 @@
 			--disable-libdirac-lavc \
 			--disable-mencoder \
 			--disable-mpg123 \
-			--disable-musepack
+			--disable-musepack \
+			--disable-mp3lib
 
 .include "${.CURDIR}/Makefile.options"
 
diff -u mplayer.orig/Makefile.options mplayer/Makefile.options
--- mplayer.orig/Makefile.options	2012-09-17 05:32:13.174238904 -0700
+++ mplayer/Makefile.options	2012-09-17 05:31:25.148241954 -0700
@@ -52,7 +52,7 @@
 .endif #WITH_DEBUG
 
 #Supported architectures for clang
-.if ${ARCH} == "amd64"
+.if ${ARCH} == "i386" || ${ARCH} == "amd64"
 MPLAYER_CLANG_SUPPORTED_ARCH=	yes
 .endif
 


>Release-Note:
>Audit-Trail:
>Unformatted: