ports/171326: [PATCH] [Mk] Fix bogus warnings in bsd.openssl/ncurses.mk when using pkgng

[Bryan Drewery]

>Number:         171326
>Category:       ports
>Synopsis:       [PATCH] [Mk] Fix bogus warnings in bsd.openssl/ncurses.mk when using pkgng
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 04 15:30:08 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Bryan Drewery
>Release:        FreeBSD 8.3-RELEASE i386
>Organization:
>Environment:

	
>Description:
	If WITH_PKGNG is defined in make.conf, trying to install (or use pkg2ng) a port that depends on ports openssl or ncurses, the following warnings are produced:

	"/usr/ports/Mk/bsd.openssl.mk", line 109: warning: "/usr/local/sbin/pkg  which -qo /usr/local/lib/libcrypto.so" returned non-zero status
	"/usr/ports/Mk/bsd.ncurses.mk", line 66: warning: "/usr/local/sbin/pkg  which -qo /usr/local/lib/libncurses.so" returned non-zero status

	The value returned is blank and the mk files are already properly accounting for that. The only problem is the bogus warning.

	The patch makes the warning go away.

>How-To-Repeat:
	# *No openssl/ncurses package registered in pkgng yet*
	# Already have security/openssl and devel/ncurses installed
	echo "WITH_PKGNG=yes" >> /etc/make.conf
	make -C /usr/ports/security/tor -VOPENSSL_PORT
	make -C /usr/ports/security/metasploit -VNCURSES_PORT
>Fix:

	

--- patch-mk-pkg-which.txt begins here ---
diff -ur Mk.orig/bsd.ncurses.mk Mk/bsd.ncurses.mk
--- Mk.orig/bsd.ncurses.mk	2012-05-06 08:54:57.000000000 -0500
+++ Mk/bsd.ncurses.mk	2012-09-04 10:20:05.000000000 -0500
@@ -63,7 +63,7 @@
 .else
 PKGARGS=
 .endif
-NCURSES_INSTALLED!=	${PKG_BIN} ${PKGARGS} which -qo ${LOCALBASE}/lib/libncurses.so
+NCURSES_INSTALLED!=	${PKG_BIN} ${PKGARGS} which -qo ${LOCALBASE}/lib/libncurses.so || :
 .else
 NCURSES_INSTALLED!=	find "${PKG_DBDIR}/" -type f -name "+CONTENTS" -print0 | \
 			xargs -0 grep -l "^lib/libncurses.so." | \
diff -ur Mk.orig/bsd.openssl.mk Mk/bsd.openssl.mk
--- Mk.orig/bsd.openssl.mk	2012-04-18 06:38:20.000000000 -0500
+++ Mk/bsd.openssl.mk	2012-09-04 10:05:53.000000000 -0500
@@ -106,7 +106,7 @@
 .else
 PKGARGS=
 .endif
-OPENSSL_INSTALLED!=	${PKG_BIN} ${PKGARGS} which -qo ${LOCALBASE}/lib/libcrypto.so
+OPENSSL_INSTALLED!=	${PKG_BIN} ${PKGARGS} which -qo ${LOCALBASE}/lib/libcrypto.so || :
 .else
 OPENSSL_INSTALLED!=	find "${PKG_DBDIR}/" -type f -name "+CONTENTS" -print0 | \
 			xargs -0 grep -l "^lib/libssl.so." | \
--- patch-mk-pkg-which.txt ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: