ports/173352: [PATCH] games/gtkatlantic: OptionsNG, changed Makefile, added Desktop entries, icons, take maintainership

[nemysis]

>Number:         173352
>Category:       ports
>Synopsis:       [PATCH] games/gtkatlantic: OptionsNG, changed Makefile, added Desktop entries, icons, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 04 05:40:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:

- Take maintainership

Makefile changed:
+LICENSE=	GPLv2
+BUILD_DEPENDS=	xpmtoppm:${PORTSDIR}/graphics/netpbm
+PORTDOCS=
+INSTALLS_ICONS=	yes
+ICON_SIZES=	16x16 32x32 48x48
+DESKTOP_ENTRIES
+.include <bsd.port.options.mk>
+post-build:
+.for s in ${ICON_SIZES}
+.if ${PORT_OPTIONS:MDOCS}

Changed pkg-plist

Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

portlint -A
WARN: Makefile: [42]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: only one MASTER_SITE configured.  Consider adding additional mirrors.
0 fatal errors and 4 warnings found.

WARN: Makefile: [42] because is used
 	@${REINPLACE_CMD} -e 's|mkdir |$$(mkdir_p) |g' ${WRKSRC}/Makefile.in

port test: clean

Build log

https://redports.org/buildarchive/20121103231908-28395/

>Fix:

--- gtkatlantic-0.4.3_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/games/gtkatlantic/Makefile ./Makefile
--- /usr/ports/games/gtkatlantic/Makefile	2012-06-01 07:18:51.000000000 +0200
+++ ./Makefile	2012-11-04 06:09:22.000000000 +0100
@@ -7,22 +7,59 @@
 
 PORTNAME=	gtkatlantic
 PORTVERSION=	0.4.3
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	games
-MASTER_SITES=	http://download.tuxfamily.org/gtkatlantic/downloads/v0.4/
+MASTER_SITES=	http://download.tuxfamily.org/${PORTNAME}/downloads/v0.4/
 
-MAINTAINER=	ports at FreeBSD.org
-COMMENT=	A game like Monopoly(tm)
+MAINTAINER=	nemysis at gmx.ch
+COMMENT=	Game like Monopoly(tm)
+
+LICENSE=	GPLv2
+
+BUILD_DEPENDS=	xpmtoppm:${PORTSDIR}/graphics/netpbm
 
 USE_BZIP2=	yes
 USE_GNOME=	gtk20
-USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
+USE_GMAKE=	yes
+
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 
+PORTDOCS=	AUTHORS ChangeLog README
+
+INSTALLS_ICONS=	yes
+ICON_SIZES=	16x16 32x32 48x48
+
+DESKTOP_ENTRIES="GtkAtlantic" "${COMMENT}" "${PORTNAME}" \
+		"${PORTNAME}" "Game;BoardGame;" ${FALSE}
+
+.include <bsd.port.options.mk>
+
 post-patch:
-	@${REINPLACE_CMD} -e '/-Werror/s|^|#|' ${WRKSRC}/configure
+	@${REINPLACE_CMD} -e 's|-Wall -Werror||' ${WRKSRC}/configure
 	@${REINPLACE_CMD} -e 's|mkdir |$$(mkdir_p) |g' ${WRKSRC}/Makefile.in
 
+post-build:
+	@(cd ${WRKSRC}/data && ${LOCALBASE}/bin/xpmtoppm icon32x32.xpm | \
+		${LOCALBASE}/bin/pamscale 1.5 | ${LOCALBASE}/bin/ppmtoxpm > icon48x48.xpm)
+
+.for s in ${ICON_SIZES}
+	@(cd ${WRKSRC}/data && ${LOCALBASE}/bin/xpmtoppm icon${s}.xpm | \
+		${LOCALBASE}/bin/pnmtopng > ${PORTNAME}${s}.png)
+.endfor
+
+post-install:
+.for s in ${ICON_SIZES}
+	${MKDIR} ${PREFIX}/share/icons/hicolor/${s}/apps
+	${INSTALL_DATA} ${WRKSRC}/data/${PORTNAME}${s}.png \
+		${PREFIX}/share/icons/hicolor/${s}/apps/${PORTNAME}.png
+.endfor
+	${LN} -sf ${PREFIX}/share/icons/hicolor/48x48/apps/${PORTNAME}.png ${PREFIX}/share/pixmaps
+
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
+
 .include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/games/gtkatlantic/pkg-plist ./pkg-plist
--- /usr/ports/games/gtkatlantic/pkg-plist	2005-03-18 01:51:49.000000000 +0100
+++ ./pkg-plist	2012-11-03 23:52:30.000000000 +0100
@@ -3,10 +3,14 @@
 %%DATADIR%%/cards.png
 %%DATADIR%%/commands.png
 %%DATADIR%%/default.conf
+%%DATADIR%%/gtkatlantic16x16.png
+%%DATADIR%%/gtkatlantic32x32.png
+%%DATADIR%%/gtkatlantic48x48.png
 %%DATADIR%%/help.index
 %%DATADIR%%/houses.png
 %%DATADIR%%/icon16x16.xpm
 %%DATADIR%%/icon32x32.xpm
+%%DATADIR%%/icon48x48.xpm
 %%DATADIR%%/interface.xml
 %%DATADIR%%/logo.png
 %%DATADIR%%/stars.png
@@ -21,6 +25,18 @@
 %%DATADIR%%/themes/generic_gradient/theme.conf
 %%DATADIR%%/themes/generic_gradient/tokens.png
 %%DATADIR%%/tokens.png
+share/icons/hicolor/16x16/apps/gtkatlantic.png
+share/icons/hicolor/32x32/apps/gtkatlantic.png
+share/icons/hicolor/48x48/apps/gtkatlantic.png
+share/pixmaps/gtkatlantic.png
+ at dirrmtry share/icons/hicolor/48x48/apps
+ at dirrmtry share/icons/hicolor/48x48
+ at dirrmtry share/icons/hicolor/32x32/apps
+ at dirrmtry share/icons/hicolor/32x32
+ at dirrmtry share/icons/hicolor/16x16/apps
+ at dirrmtry share/icons/hicolor/16x16
+ at dirrmtry share/icons/hicolor
+ at dirrmtry share/icons
 @dirrm %%DATADIR%%/themes/generic_gradient
 @dirrm %%DATADIR%%/themes
 @dirrm %%DATADIR%%
--- gtkatlantic-0.4.3_2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: