ports/165775: mail/dma FTBFS

[Gordon Shumway]

>Number:         165775
>Category:       ports
>Synopsis:       mail/dma FTBFS
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 06 14:30:15 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Gordon Shumway
>Release:        8.2-stable
>Organization:
>Environment:
FreeBSD localhost.localdomain 8.2-RELEASE-p6 FreeBSD 8.2-RELEASE-p6 #0: Thu Jan 19 21:50:00 CET 2012     root at localhost.localdomain:/usr/obj/usr/src/sys/DTRACE  amd64
>Description:
cc -O2 -pipe -fno-omit-frame-pointer -I/usr/local/include -DCONF_PATH='"/usr/local/etc/dma"' -DDMA_ROOT_USER='"mailnull"' -DDMA_GROUP='"mail"' -fno-strict-aliasing -fno-omit-frame-pointer  -I/usr/ports/mail/dma/work/corecode-dma-db9a42b/dma -I/usr/ports/mail/dma/work/corecode-dma-db9a42b/dma/.. -DHAVE_REALLOCF -DHAVE_STRLCPY -DHAVE_GETPROGNAME -DLIBEXEC_PATH='"/usr/local/libexec"' -DDMA_VERSION='"v0.7"' -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wno-pointer-sign -c /usr/ports/mail/dma/work/corecode-dma-db9a42b/dma/..//crypto.c

cc1: warnings being treated as errors
/usr/ports/mail/dma/work/corecode-dma-db9a42b/dma/..//crypto.c: In function 'smtp_init_crypto':
/usr/ports/mail/dma/work/corecode-dma-db9a42b/dma/..//crypto.c:92: warning: assignment discards qualifiers from pointer target type

this is actually caused by files/patch-crypto.c which is plain wrong for openssl v1.0 (port version), but is correct for openssl 0.9 (base version). according to Mk/bsd.openssl.mk, the port build will prefer the ports-installed version, rendering the patch unusable for anyone having security/openssl installed.

>How-To-Repeat:
- have security/openssl installed
- try installing mail/dma

>Fix:
files/patch-crypto.c should be made conditional based upon OPENSSL_VERSION_NUMBER (or something similar).

>Release-Note:
>Audit-Trail:
>Unformatted: